Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-update: fix darwin build #46625

Merged
merged 1 commit into from Sep 13, 2018
Merged

cargo-update: fix darwin build #46625

merged 1 commit into from Sep 13, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 13, 2018

Motivation for this change

On darwin libcurl is also needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
cargo-update: fix darwin build
d33c289 
On darwin libcurl is also needed.

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cargo-update

Partial log (click to expand)

warning: redundant linker flag specified for library `ssl`

warning: redundant linker flag specified for library `z`

installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ffvmydvhcc86zrkky1wap9wv62hy4b0q-cargo-update-1.5.2/lib  /nix/store/ffvmydvhcc86zrkky1wap9wv62hy4b0q-cargo-update-1.5.2/bin
patching script interpreter paths in /nix/store/ffvmydvhcc86zrkky1wap9wv62hy4b0q-cargo-update-1.5.2
/nix/store/ffvmydvhcc86zrkky1wap9wv62hy4b0q-cargo-update-1.5.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-update

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2
shrinking /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2/bin/cargo-install-update-config
shrinking /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2/bin/cargo-install-update
shrinking /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2/lib/cargo-update/build_script_build
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2/lib  /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2/bin
patching script interpreter paths in /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2
checking for references to /build in /nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2...
/nix/store/9vpzkazrsb9gv8k68m78mzzx9nryf14b-cargo-update-1.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-update

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2
shrinking /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2/bin/cargo-install-update-config
shrinking /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2/bin/cargo-install-update
shrinking /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2/lib/cargo-update/build_script_build
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2/lib  /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2/bin
patching script interpreter paths in /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2
checking for references to /build in /nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2...
/nix/store/sm487g4f6rxlg079l26p8yv4w4bqdb0n-cargo-update-1.5.2

@xeji xeji merged commit d782c4e into NixOS:master Sep 13, 2018
xeji pushed a commit that referenced this pull request Sep 13, 2018
@LnL7 @xeji
cargo-update: fix darwin build (#46625)
ce1f20f 
On darwin libcurl is also needed.

/cc ZHF #45961

(cherry picked from commit d782c4e)
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

backported: ce1f20f

@LnL7 LnL7 deleted the darwin-cargo-update branch September 13, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji