Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: fix some broken builds #46608

Merged
merged 6 commits into from Sep 14, 2018
Merged

pythonPackages: fix some broken builds #46608

merged 6 commits into from Sep 14, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 13, 2018 •
edited

Motivation for this change

ZHF #45960. Fix various broken python packages.

Things done
  • Built in sandbox on NixOS x86_64-linux
  • passes nix-review

@xeji xeji requested a review from FRidh as a code owner September 13, 2018 14:34
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python36Packages.daphne python36Packages.channels

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)

Successfully installed channels-2.1.3
/build/channels-2.1.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3/lib
patching script interpreter paths in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3
checking for references to /build in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3...
/nix/store/dfkz790ci59y942a7s5377bx8a9kn127-python3.6-daphne-2.2.2
/nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)

Successfully installed channels-2.1.3
/build/channels-2.1.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3/lib
patching script interpreter paths in /nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3
checking for references to /build in /nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3...
/nix/store/v214m4igqww33hvyj8nfhw7z8zzidh8r-python3.6-daphne-2.2.2
/nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)


tests/test_websocket.py::TestWebsocket::test_http_bits
  /nix/store/3hzkfm9cmyp1g7j82vghl8gyfs7qhyg8-python3.6-hypothesis-3.66.2/lib/python3.6/site-packages/hypothesis/strategies.py:588: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    check_valid_sizes(min_size, average_size, max_size)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============== 27 failed, 21 passed, 9 warnings in 149.82 seconds ==============
builder for '/nix/store/k5934q5ck2q9iqhlf1z2rsq6rnc52pp7-python3.6-daphne-2.2.2.drv' failed with exit code 1
cannot build derivation '/nix/store/f7z19gxchfqfk0jp73dgy2yqqynq6xqb-python3.6-channels-2.1.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f7z19gxchfqfk0jp73dgy2yqqynq6xqb-python3.6-channels-2.1.3.drv', '/nix/store/k5934q5ck2q9iqhlf1z2rsq6rnc52pp7-python3.6-daphne-2.2.2.drv' failed

@xeji
pythonPackages.daphne: 2.1.0 -> 2.2.2
abe97e9 
Update, re-enable all tests on linux, disable tests on darwin.
This fixes the build of pythonPackages.channels
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python36Packages.daphne python36Packages.channels

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)

/nix/store/v214m4igqww33hvyj8nfhw7z8zzidh8r-python3.6-daphne-2.2.2
/nix/store/wv6z181m124n1hh69yf8p28azpmkra0s-python3.6-channels-2.1.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)

Requirement already satisfied: idna>=2.5 in /nix/store/6d5iv9w1k93gcnd2aw3dl7z9gkkga9c4-python3.6-idna-2.7/lib/python3.6/site-packages (from hyperlink>=17.1.1->twisted>=18.7->daphne~=2.2->channels==2.1.3) (2.7)
Installing collected packages: channels
Successfully installed channels-2.1.3
/private/tmp/nix-build-python3.6-channels-2.1.3.drv-0/channels-2.1.3
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zw02k6hd3nmrn5r1p7by9ifdzxd65fv-python3.6-channels-2.1.3/lib
patching script interpreter paths in /nix/store/6zw02k6hd3nmrn5r1p7by9ifdzxd65fv-python3.6-channels-2.1.3
/nix/store/ng0qx7gg2sj6iq11mlv8rnl877fdcl62-python3.6-daphne-2.2.2
/nix/store/6zw02k6hd3nmrn5r1p7by9ifdzxd65fv-python3.6-channels-2.1.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.daphne, python36Packages.channels

Partial log (click to expand)

Successfully installed channels-2.1.3
/build/channels-2.1.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3/lib
patching script interpreter paths in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3
checking for references to /build in /nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3...
/nix/store/dfkz790ci59y942a7s5377bx8a9kn127-python3.6-daphne-2.2.2
/nix/store/glbhvpkbgpnb8cdi0rv9140g0vmkyc68-python3.6-channels-2.1.3

@xeji
pythonPackages.eve: fix build, drop incorrect dependencies
9e4b0b7 
Build failed because of dependency Flask-PyMongo, which actually
isn't a dependency of eve as they have their own flask_pymongo code.

- Drop incorrect dependency flask-pymongo
- Drop redunant dependencies already propageted by flask:
  itsdangerous, werkzeug, jinja2
- Drop dependency markupsafe, not required any more
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python27Packages.eve python36Packages.eve

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.eve, python36Packages.eve

Partial log (click to expand)

Successfully installed Eve-0.8
/build/Eve-0.8
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5gxdjr4gwpz6ll3ycs5600b5ym9z6gbr-python3.6-Eve-0.8
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5gxdjr4gwpz6ll3ycs5600b5ym9z6gbr-python3.6-Eve-0.8/lib
patching script interpreter paths in /nix/store/5gxdjr4gwpz6ll3ycs5600b5ym9z6gbr-python3.6-Eve-0.8
checking for references to /build in /nix/store/5gxdjr4gwpz6ll3ycs5600b5ym9z6gbr-python3.6-Eve-0.8...
/nix/store/j3jhzr2fc7f12lq1akxb5cammz5652qj-python2.7-Eve-0.8
/nix/store/5gxdjr4gwpz6ll3ycs5600b5ym9z6gbr-python3.6-Eve-0.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.eve, python36Packages.eve

Partial log (click to expand)

Requirement already satisfied: MarkupSafe>=0.23 in /nix/store/5f53wy70y3ifxymjhpf6r9891qksijhp-python3.6-markupsafe-1.0/lib/python3.6/site-packages (from Jinja2>=2.10->flask>=1.0->Eve==0.8) (1.0)
Installing collected packages: Eve
Successfully installed Eve-0.8
/private/tmp/nix-build-python3.6-Eve-0.8.drv-0/Eve-0.8
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qrdvangn8sl6pj50y9iijglb0d8nq3m-python3.6-Eve-0.8/lib
patching script interpreter paths in /nix/store/4qrdvangn8sl6pj50y9iijglb0d8nq3m-python3.6-Eve-0.8
/nix/store/3fhsz6njf1hpx9h17lh9x4m4yzlyxm14-python2.7-Eve-0.8
/nix/store/4qrdvangn8sl6pj50y9iijglb0d8nq3m-python3.6-Eve-0.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.eve, python36Packages.eve

Partial log (click to expand)

Successfully installed Eve-0.8
/build/Eve-0.8
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kcgvyjxk848fni8x7q85g8r6ag76v64v-python3.6-Eve-0.8
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kcgvyjxk848fni8x7q85g8r6ag76v64v-python3.6-Eve-0.8/lib
patching script interpreter paths in /nix/store/kcgvyjxk848fni8x7q85g8r6ag76v64v-python3.6-Eve-0.8
checking for references to /build in /nix/store/kcgvyjxk848fni8x7q85g8r6ag76v64v-python3.6-Eve-0.8...
/nix/store/jd1qiqk1q3f5jdvra3kw673mnsxpq6w6-python2.7-Eve-0.8
/nix/store/kcgvyjxk848fni8x7q85g8r6ag76v64v-python3.6-Eve-0.8

@xeji
pythonPackages.flask-pymongo: fix build
781eaa1 
add missing dependency: vcversioner
@xeji
pythonPackages.pytest-rerunfailures: fix build
0bda601 
some tests fail since pytest 3.7.2 -> 3.7.4 update, disable them
@xeji
pythonPackages.wordfreq: 2.0 -> 2.2.0, fix build
be12bb8 
Previous version didn't build (test failure).
Update to latest, tests use pytest now, disable failing tests.
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python27Packages.flask-pymongo python36Packages.flask-pymongo python27Packages.pytest-rerunfailures python36Packages.pytest-rerunfailures python36Packages.wordfreq

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.flask-pymongo, python36Packages.flask-pymongo, python27Packages.pytest-rerunfailures, python36Packages.pytest-rerunfailures, python36Packages.wordfreq

Partial log (click to expand)

tests/test_chinese.py ...                                                [ 25%]
tests/test_general.py ...............                                    [ 87%]
tests/test_transliteration.py ...                                        [100%]

=================== 24 passed, 9 deselected in 4.71 seconds ====================
/nix/store/pl6m9s98k9giblsa2b46g53jvaczyfbj-python2.7-Flask-PyMongo-2.1.0
/nix/store/zfww8j0146a7qhav7grkjp7yr096dan1-python3.6-Flask-PyMongo-2.1.0
/nix/store/yq9zxh5w6dm23zdqrqq8bzwcabfh6iz3-python2.7-pytest-rerunfailures-4.1
/nix/store/rr2xvjbfzh48a1zskyy8nax3gpy2f6fv-python3.6-pytest-rerunfailures-4.1
/nix/store/0laqakjzzvycxv38kgvl9anpc4nnb668-python3.6-wordfreq-2.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.flask-pymongo, python36Packages.flask-pymongo, python27Packages.pytest-rerunfailures, python36Packages.pytest-rerunfailures, python36Packages.wordfreq

Partial log (click to expand)

tests/test_chinese.py ...                                                [ 25%]
tests/test_general.py ...............                                    [ 87%]
tests/test_transliteration.py ...                                        [100%]

=================== 24 passed, 9 deselected in 4.96 seconds ====================
/nix/store/gnz1h3r5gdzd6lz4j56p3yabbhqfb6n0-python2.7-Flask-PyMongo-2.1.0
/nix/store/ds6ijl3ch1wgnshpqfzfgawlrp4x3gra-python3.6-Flask-PyMongo-2.1.0
/nix/store/nx9qz4p59kd2sxn9d5krr89plwdkcssv-python2.7-pytest-rerunfailures-4.1
/nix/store/jrlf4cz773wnylsfw708gb5vk67rd4mk-python3.6-pytest-rerunfailures-4.1
/nix/store/yyh5pq90w8abld3nhff653df4db8vajn-python3.6-wordfreq-2.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.flask-pymongo, python36Packages.flask-pymongo, python27Packages.pytest-rerunfailures, python36Packages.pytest-rerunfailures, python36Packages.wordfreq

Partial log (click to expand)

tests/test_chinese.py ...                                                [ 25%]
tests/test_general.py ...............                                    [ 87%]
tests/test_transliteration.py ...                                        [100%]

=================== 24 passed, 9 deselected in 18.00 seconds ===================
/nix/store/9y2w7vzaac69p2s7h0h40w3nn37cswys-python2.7-Flask-PyMongo-2.1.0
/nix/store/ps35bis0dp7jkp74jy6w390ip16d10w3-python3.6-Flask-PyMongo-2.1.0
/nix/store/yxzzb4a7kgn119mwz10rs2a80ln6ks3g-python2.7-pytest-rerunfailures-4.1
/nix/store/rya49ai9wda64ggrmpd7wgp8hhzmmiwf-python3.6-pytest-rerunfailures-4.1
/nix/store/i96bndj2rlpdw10ic3lgnh3bsdznszcr-python3.6-wordfreq-2.2.0

@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python27Packages.nilearn python36Packages.nilearn

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/input_data/nifti_spheres_masker.py     116     92    21%
nilearn/masking.py                             196     39    80%
nilearn/signal.py                              169     55    67%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2433    39%
----------------------------------------------------------------------
Ran 161 tests in 6.086s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/signal.py                              169     55    67%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2433    39%
----------------------------------------------------------------------
Ran 161 tests in 7.556s

OK
/nix/store/wrzignqy34k5nhcafibf9ag7v2dqqgcm-python2.7-nilearn-0.4.2
/nix/store/3g92356qfqll5cfqmwm5yv1qf7syv9nm-python3.6-nilearn-0.4.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/signal.py                              169     55    67%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2433    39%
----------------------------------------------------------------------
Ran 161 tests in 61.700s

OK
/nix/store/fgabfnnl13h0p5fa2n1h4vzsldp1h3qn-python2.7-nilearn-0.4.2
/nix/store/3f4pl6q66l906irpzac21d3f54dx0isc-python3.6-nilearn-0.4.2

@xeji xeji changed the title [WIP] pythonPackages: fix some broken builds pythonPackages: fix some broken builds Sep 13, 2018
@xeji xeji merged commit f1f8ce8 into NixOS:master Sep 14, 2018
@xeji xeji deleted the p/python-fixes-2 branch September 14, 2018 08:57
@xeji
Copy link
Contributor Author

xeji commented Sep 14, 2018

backported: 8a93d25..5eb4258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg