Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brlaser: cleanup and mark linux only #46622

Merged
merged 1 commit into from Sep 13, 2018
Merged

brlaser: cleanup and mark linux only #46622

merged 1 commit into from Sep 13, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 13, 2018 •
edited

The test binaries depend use open_memstream which isn't available on
darwin.

error: use of undeclared identifier 'open_memstream'

/cc ZHF #45961

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
brlaser: cleanup and mark linux only
e91fb4b 
The test binaries depend use open_memstream which isn't available on
darwin.

    error: use of undeclared identifier 'open_memstream'

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: brlaser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: brlaser

Partial log (click to expand)

-- Install configuration: "Release"
-- Installing: /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4/$out/lib/cups/filter/rastertobrlaser
-- Installing: /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4/$out/share/cups/drv/brlaser.drv
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4
shrinking /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4/$out/lib/cups/filter/rastertobrlaser
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4
checking for references to /build in /nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4...
/nix/store/9fxwfdd81n0x2xn8i05yyl75sf1bc45g-brlaser-4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: brlaser

Partial log (click to expand)

-- Install configuration: "Release"
-- Installing: /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4/$out/lib/cups/filter/rastertobrlaser
-- Installing: /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4/$out/share/cups/drv/brlaser.drv
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4
shrinking /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4/$out/lib/cups/filter/rastertobrlaser
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4
checking for references to /build in /nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4...
/nix/store/1x3ml46xh77k54zkfqc5dh94srhf429a-brlaser-4

@xeji xeji merged commit 04cba83 into NixOS:master Sep 13, 2018
xeji pushed a commit that referenced this pull request Sep 13, 2018
@LnL7 @xeji
brlaser: cleanup and mark linux only (#46622)
381c09b 
The test binaries depend use open_memstream which isn't available on
darwin.

    error: use of undeclared identifier 'open_memstream'

/cc ZHF #45961

(cherry picked from commit 04cba83)
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

backported: 381c09b

@LnL7 LnL7 deleted the darwin-broken-b branch September 13, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji