New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
any-nix-shell: init at 1.0.0 #46630
any-nix-shell: init at 1.0.0 #46630
Conversation
6a97717
to
470d965
Compare
11f127a
to
9e3ef82
Compare
cp -r bin $out | ||
wrapProgram $out/bin/any-nix-shell --prefix PATH ":" $out/bin | ||
wrapProgram $out/bin/any-nix-shell-wrapper | ||
wrapProgram $out/bin/nix-shell-info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wrap the last two if you don't specify any action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are bash scripts and wrapping them causes them to find bash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this happens automatically during fixupPhase
(https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/setup-hooks/patch-shebangs.sh) and it has nothing to do with the makeWrapper
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are exactly right and I removed the unnecessary wrappers.
9e3ef82
to
81a2bdd
Compare
This PR is superseded by #46743 |
Motivation for this change
any-nix-shell adds fish and zsh support for nix-shell. More supported shells can be added in the future.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)