Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceres-solver: fix darwin build #46626

Merged
merged 1 commit into from Sep 13, 2018
Merged

ceres-solver: fix darwin build #46626

merged 1 commit into from Sep 13, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 13, 2018

The Basel BUILD file conflicts with the cmake build directory on
case-insensitive filesystems, eg. darwin.

/cc ZHF #45961

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
ceres-solver: fix darwin build
adb79e0 
The Basel BUILD file conflicts with the cmake build directory on
case-insensitive filesystems, eg. darwin.

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ceres-solver

Partial log (click to expand)

/nix/store/d0n1wq2m7ccaca6zism9w7asp5mdvi1y-ceres-solver-1.14.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ceres-solver

Partial log (click to expand)

-- Found Eigen version 3.2.10: /nix/store/ark1wnkz68pllpxgmxrkmr7azzwj0947-eigen-3.2.10/include/eigen3
CMake Error at CMakeLists.txt:225 (message):
  -- Ceres requires Eigen version >= 3.3.4 on aarch64.  Detected version of
  Eigen is: 3.2.10.


-- Configuring incomplete, errors occurred!
See also "/build/ceres-solver-1.14.0/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/99i998dz0hpsjpzxbrb9k7w3k07qyaxb-ceres-solver-1.14.0.drv' failed with exit code 1
error: build of '/nix/store/99i998dz0hpsjpzxbrb9k7w3k07qyaxb-ceres-solver-1.14.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ceres-solver

Partial log (click to expand)

-- Installing: /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0/lib64/cmake/Ceres/FindGflags.cmake
-- Installing: /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0/lib64/libceres.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0/lib64
patching script interpreter paths in /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0
checking for references to /build in /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0...
moving /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0/lib64/* to /nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0/lib
/nix/store/9j7bv5r05037lvwxxhx0xgr4fhm16lwy-ceres-solver-1.14.0

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

aarch64 failure is unrelated

@xeji xeji merged commit 807b010 into NixOS:master Sep 13, 2018
xeji pushed a commit that referenced this pull request Sep 13, 2018
@LnL7 @xeji
ceres-solver: fix darwin build (#46626)
0b3e0cd 
The Basel BUILD file conflicts with the cmake build directory on
case-insensitive filesystems, eg. darwin.

/cc ZHF #45961

(cherry picked from commit 807b010)
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

backported: 0b3e0cd

@LnL7 LnL7 deleted the darwin-ceres-solver branch September 13, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji