Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkManager: fix VPN service source locations #46611

Closed
wants to merge 1 commit into from
Closed

NetworkManager: fix VPN service source locations #46611

wants to merge 1 commit into from

Conversation

benley
Copy link
Member

@benley benley commented Sep 13, 2018

Motivation for this change

These have all moved to lib/NetworkManager/VPN in the plugin build outputs rather than etc/NetworkManager/VPN. This fixes the symlinks so NetworkManager can find its vpn plugins again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@benley
NetworkManager: fix VPN service source locations
c7754c1 
These have all moved to lib/NetworkManager/VPN in the plugin build
outputs rather than etc/NetworkManager/VPN.  This fixes the symlinks
so NetworkManager can find its vpn plugins again.
@jtojnar
Copy link
Contributor

jtojnar commented Sep 13, 2018

See #46201

@benley
Copy link
Member Author

benley commented Sep 13, 2018

ugh sorry, I forgot to rebase against current master before opening this PR.

@benley benley closed this Sep 13, 2018
@benley benley deleted the nm-plugin-dir branch September 13, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @jtojnar @GrahamcOfBorg