Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calaos_installer: fix darwin install #46629

Merged
merged 1 commit into from Sep 13, 2018
Merged

calaos_installer: fix darwin install #46629

merged 1 commit into from Sep 13, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 13, 2018

Motivation for this change

On darwin this builds an application instead of a binary.

/cc ZHF #45961

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
calaos_installer: fix darwin install
1566c82 
On darwin this builds an application instead of a binary.

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: calaos_installer

Partial log (click to expand)

/nix/store/y40adf87sg46pqlh182yp0lr8wikrb73-calaos_installer-3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: calaos_installer

Partial log (click to expand)

these paths will be fetched (1.62 MiB download, 3.71 MiB unpacked):
  /nix/store/3cy852q4b2b8r76b71j7l9vizc1id4xy-calaos_installer-3.1
copying path '/nix/store/3cy852q4b2b8r76b71j7l9vizc1id4xy-calaos_installer-3.1' from 'https://cache.nixos.org'...
/nix/store/3cy852q4b2b8r76b71j7l9vizc1id4xy-calaos_installer-3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: calaos_installer

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1
shrinking /nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1/bin/calaos_installer
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1/bin
patching script interpreter paths in /nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1
checking for references to /build in /nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/2kwvk4pilm6pv1mmsg62drhg3insvfc6-calaos_installer-3.1

@xeji xeji merged commit 6895655 into NixOS:master Sep 13, 2018
xeji pushed a commit that referenced this pull request Sep 13, 2018
@LnL7 @xeji
calaos_installer: fix darwin install (#46629)
4199eb4 
On darwin this builds an application instead of a binary.

/cc ZHF #45961

(cherry picked from commit 6895655)
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

backported: 4199eb4

@LnL7 LnL7 deleted the darwin-calaos-installer branch September 13, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji