Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftag: 1.0.4 -> 1.0.5 #46633

Merged
merged 1 commit into from Sep 14, 2018
Merged

pdftag: 1.0.4 -> 1.0.5 #46633

merged 1 commit into from Sep 14, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Sep 13, 2018 •
edited

Motivation for this change

New release that removes hard coded path and unnecessary license install, also see #45666

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@leenaars leenaars mentioned this pull request Sep 13, 2018
Merged
9 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Sep 13, 2018

@GrahamcOfBorg build pdftag

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pdftag

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5/bin/pdftag
shrinking RPATHs of ELF executables and libraries in /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5
shrinking /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5/bin/.pdftag-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5/bin
patching script interpreter paths in /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5
checking for references to /build in /nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5...
/nix/store/386xq7cv7s6wc58ydcsvig8iv7ccmida-pdftag-1.0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pdftag

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5/bin/pdftag
shrinking RPATHs of ELF executables and libraries in /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5
shrinking /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5/bin/.pdftag-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5/bin
patching script interpreter paths in /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5
checking for references to /build in /nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5...
/nix/store/h0w8k4azjbk1hfy5s40c7pa40ia58dp5-pdftag-1.0.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pdftag

Partial log (click to expand)

Installing pdftag to /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5/bin/pdftag
Installing /private/tmp/nix-build-pdftag-1.0.5.drv-0/source/LICENSE to /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5/share/licenses/pdftag
Installing /private/tmp/nix-build-pdftag-1.0.5.drv-0/source/data/pdftag.desktop to /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5/share/applications
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5/bin/pdftag
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5/bin
patching script interpreter paths in /nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5
/nix/store/b754sl006nyb2hp9dywcvmink5ax45wm-pdftag-1.0.5

@jtojnar
Copy link
Contributor

jtojnar commented Sep 14, 2018

Thanks.

@jtojnar jtojnar merged commit 217c795 into NixOS:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @jtojnar @GrahamcOfBorg