Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-env: init at 0.4 #47414

Merged
merged 1 commit into from Oct 8, 2018
Merged

aws-env: init at 0.4 #47414

merged 1 commit into from Oct 8, 2018

Conversation

ento
Copy link
Contributor

@ento ento commented Sep 27, 2018

Motivation for this change

This PR adds aws-env, a useful tool for pulling environment-specific variables from AWS Systems Manager Parameter Store.

The contributing guide requires that meta.maintainers be set; I'm not really good at being a maintainer - what'd be the protocol in that case?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Sep 28, 2018

@GrahamcOfBorg build aws-env

@ento I don't believe it's a hard requirement that new packages absolutely must have a maintainer, but it certainly is preferable by a large margin, so that people at least have someone to ping on github to ask for reviews of version bumps etc.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: aws-env

Partial log (click to expand)

Cannot nix-instantiate `aws-env' because:
error: attribute 'aws-env' in selection path 'aws-env' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: aws-env

Partial log (click to expand)

Cannot nix-instantiate `aws-env' because:
error: attribute 'aws-env' in selection path 'aws-env' not found

srhb
srhb requested changes Sep 28, 2018
View reviewed changes
pkgs/tools/admin/aws-env/default.nix Outdated Show resolved Hide resolved
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: aws-env

Partial log (click to expand)

Cannot nix-instantiate `aws-env' because:
error: attribute 'aws-env' in selection path 'aws-env' not found

@srhb
Copy link
Contributor

srhb commented Sep 28, 2018

Ah, this needs an entry in pkgs/top-level/all-packages.nix in order to be addressable as an attribute.

@ento
Copy link
Contributor Author

ento commented Sep 28, 2018

D'oh, added to all-packages.nix in 6e8a5b0. I can squash the commits if that's preferable.

re: maintainer - got it. Is the ping more for Nix expertise or for knowledge of the package content itself?

@srhb
Copy link
Contributor

srhb commented Sep 29, 2018

@ento I'd say in this case where it's a relative simple package, the question that people will mostly be aiming at the maintainer is probably "hey, I updated this package, is that OK?"

And yes please, squash 'em. :)

@srhb
Copy link
Contributor

srhb commented Sep 29, 2018

@GrahamcOfBorg build aws-env

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-env

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin
shrinking /nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin/bin/aws-env
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin/bin
patching script interpreter paths in /nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin
checking for references to /build in /nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/hirysfpkgwbmkjjqyrnahn48mnd3gyq8-aws-env-0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aws-env

Partial log (click to expand)

find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
find: '/nix/store/110sbxhjfa87a3pd1y2w3bgxqg12plbl-aws-env-0.4': No such file or directory
/nix/store/fsvk8f3qrhmgn21wzn848iriymdcm269-aws-env-0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-env

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin
shrinking /nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin/bin/aws-env
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin/bin
patching script interpreter paths in /nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin
checking for references to /build in /nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/7gi1dcjvdhfh3v60d0ikckf54vi5imnl-aws-env-0.4-bin

@ento
Copy link
Contributor Author

ento commented Oct 2, 2018

They've been squashed.

"hey, I updated this package, is that OK?"

Being a mere user of aws-env, I'll only be able to say "I guess?" and double-check any open issues for aws-env at most. So I'll cc @orfin for any interest in having your name listed as a maintainer / point of contact for aws-env in Nix (if there's interest, we can update the package metadata in a separate PR), and ask the good reviewer(s) of nixpkgs to consider it a non-blocker to have no maintainer listed for this package for now.

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

@ento Alright, but I'd feel bad adding a package with no maintainer, so can you please add me (stdenv.lib.maintainers.srhb) for now and resquash, and I'll take it upon me to forward any request that requires deeper knowledge of the tool to relevant people.

@ento
Copy link
Contributor Author

ento commented Oct 8, 2018

@srhb Thank you, much appreciated. I've updated maintainers and force-pushed.

@srhb
Copy link
Contributor

srhb commented Oct 8, 2018

Thank you. :)

@srhb srhb merged commit ac35f4e into NixOS:master Oct 8, 2018
@ento ento deleted the add-aws-env branch October 8, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ento @srhb @GrahamcOfBorg