abi-compliance-checker: init at 2.3 #47408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build abi-compliance-checker |
|
Success on x86_64-linux (full log) Attempted: abi-compliance-checker Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: abi-compliance-checker Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
orivej
suggested changes
Sep 26, 2018
| installPhase = '' | ||
| make prefix=$out install | ||
| ''; | ||
|
|
There was a problem hiding this comment.
Could you add makeFlags = [ "prefix=$(out)" ]; and delete the phases? (all is the default target of vtable-dumper.)
There was a problem hiding this comment.
Updated in all 3 packages (along with the meta improvement). Looks a lot nicer now and I learned a new trick with the makeFlags; thanks @orivej!
abi-dumper still needs a preBuild = "mkdir -p $out";, since the Makefile shells out to perl to do its install and will fail if the install dir does not exist, but for the other ones I could delete everything and make it much cleaner.
| make prefix=$out install | ||
| ''; | ||
|
|
||
| meta = with stdenv; { |
There was a problem hiding this comment.
We generally write meta = with stdenv.lib;.
| @@ -7924,6 +7924,8 @@ with pkgs; | |||
|
|
|||
| abi-dumper = callPackage ../development/tools/misc/abi-dumper { }; | |||
|
|
|||
| abi-compliance-checker = callPackage ../development/tools/misc/abi-compliance-checker { }; | |||
There was a problem hiding this comment.
Could you put this before abi-dumper to keep them sorted?
There was a problem hiding this comment.
Ah thanks for the catch; not sure how I missed that (I'm usually very OCD about sorting).
bhipple
force-pushed
the
add/abi-tools
branch
from
5fb609b
to
3aaa8ad
Compare
|
Success on aarch64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
|
Ping? Happy to iterate further, but AFAIK this is good to go now. |
|
could you fixup the code review changes into their respective commits? ie: |
|
Can-do; I cleaned up the commit history and rebased onto the latest origin/master. |
|
Success on aarch64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: abi-compliance-checker, abi-dumper, vtable-dumper Partial log (click to expand)
|
jb55
approved these changes
Oct 7, 2018
|
Ping @orivej mind taking a look? Should be ready to merge I think. |
|
CC @matthewbauer would you mind reviewing please? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds
abi-compliance-checkerand its two dependencies, for dumping the API/ABI of C/C++ libraries. It is the tool used to produce the reports on this webpage:https://abi-laboratory.pro/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)