Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: 3.0.3 -> 3.0.4 #47406

Merged
merged 1 commit into from Sep 26, 2018
Merged

vlc: 3.0.3 -> 3.0.4 #47406

merged 1 commit into from Sep 26, 2018

Conversation

coreyoconnor
Copy link
Contributor

Motivation for this change
  • vlc 3.0.3 does not compile due to missing vlc-qt5.11.patch
  • update

Both patches appear unnecessary now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vlc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: Media.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
builder for '/nix/store/h418wwalkqzw97jd3rsfqzv27c38z8fl-live555-2018.02.28.drv' failed with exit code 2
copying path '/nix/store/a7zf6hzv4am9dar25mxsy71196ir6wsp-samba-4.7.9-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/1ipr93n66mkp666khnnkfc5kmxh6y2dy-ffmpeg-3.4.4-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/ii63767j4m2mszmp0bl6k1v3p51rc8hd-ffmpeg-3.4.4-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/pmlyvyry85cvlvsbhsmzd824hdk0bx0x-vlc-3.0.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pmlyvyry85cvlvsbhsmzd824hdk0bx0x-vlc-3.0.4.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 26, 2018

aarch64 failure is unrelated, live555 has been broken on aarch64 for a while

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4...
postPatchMkspecs
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4

xeji
xeji approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@xeji xeji merged commit 26ce265 into NixOS:master Sep 26, 2018
xeji pushed a commit that referenced this pull request Sep 26, 2018
@coreyoconnor @xeji
vlc: 3.0.3 -> 3.0.4 (#47406)
d26e830 
(cherry picked from commit 26ce265)

Didn't build, invalid url for vlc-qt5.11.patch.
@xeji
Copy link
Contributor

xeji commented Sep 26, 2018

backported to 18.09 because of broken patch url: d26e830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coreyoconnor @GrahamcOfBorg @xeji