gradient_halide: init at 2018-08-31 #46349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
requested changes
Sep 23, 2018
| # Another way is using "make halide_archive", but the tarball is not easy | ||
| # to disassemble. | ||
| installPhase = '' | ||
| find |
There was a problem hiding this comment.
I don't exactly understand your comment. The default installPhase doesn't install things correctly; did you have some alternative in mind?
| sha256 = "0qhk1plc4697p1livf9xz2c5aqaq6v9sx1pr0ia6x7sjkmggc9rc"; | ||
| }; | ||
|
|
||
| patches = [ ./nix.patch ]; |
There was a problem hiding this comment.
Do you think it would be possible to upstream some of these patches?
There was a problem hiding this comment.
Perhaps, but I didn't make these patches myself so I don't know exactly what would we involved. However, it looks like I might soon create an issue/PR against the stock halide NIx package so perhaps I'll suggest it there.
bcdarwin
force-pushed
the
gradient-halide
branch
from
25e94b1
to
d8e3056
Compare
|
Are there any updates on this pull request, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halide extended with autodiff as described in Differentiable Programming for
Image Processing and Deep Learning in Halide.
Gradient Halide is implemented in a separate repository from stock Halide, hence this package. At the moment, I've simply copied the existing Halide expression since there are minimal differences. It seems like I should factor the two expressions but I'm not sure of the appropriate directory structure. Of course, hopefully the two repositories will soon merge and this will be irrelevant anyway.
The tests seem to be getting built but I couldn't immediately figure out how to run them when building, but I've compiled and run a couple examples against the library.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)