Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/wavemon: create module #46330

Merged
merged 1 commit into from Oct 28, 2018
Merged

nixos/wavemon: create module #46330

merged 1 commit into from Oct 28, 2018

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Sep 7, 2018

Motivation for this change

Creates a new NixOS module to enable wavemon and its capabilities.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@oxzi
Copy link
Member Author

oxzi commented Sep 16, 2018

Any comment on this PR?

@joachifm joachifm merged commit e5ce19f into NixOS:master Oct 28, 2018
@oxzi oxzi deleted the wavemon-module branch October 28, 2018 10:18
@oxzi oxzi restored the wavemon-module branch March 10, 2019 21:32
@oxzi oxzi deleted the wavemon-module branch March 10, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @joachifm @GrahamcOfBorg