ripgrep: 0.9.0 -> 0.10.0 #46331

dywedir · 2018-09-07T18:50:20Z

0.10.0 (2018-09-07)

Major new features include PCRE2 support, multi-line search and a JSON output format.

closes #46350

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

cc @tailhook

dywedir · 2018-09-07T18:51:27Z

pkgs/tools/text/ripgrep/default.nix

@@ -1,19 +1,24 @@
-{ stdenv, fetchFromGitHub, rustPlatform, asciidoc, docbook_xsl, libxslt  }:
+{ stdenv, fetchFromGitHub, rustPlatform, asciidoc, docbook_xsl, libxslt
+, withPCRE2 ? false, pcre2 ? null


or withPcre2
or withpcre2?

I think it's fine as is. Camel casing looks weird for abbreviations anyway.

GrahamcOfBorg · 2018-09-07T19:08:48Z

Success on aarch64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

post-installation fixup
moving /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/man to /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0
shrinking /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/bin/rg
gzipping man pages under /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0
checking for references to /build in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0...
/nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-07T19:10:02Z

Success on x86_64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

post-installation fixup
moving /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/man to /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
shrinking /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin/rg
gzipping man pages under /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
checking for references to /build in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0...
/nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0

xeji · 2018-09-07T23:18:05Z

let's check darwin build
@GrahamcOfBorg build ripgrep

GrahamcOfBorg · 2018-09-07T23:18:13Z

Success on x86_64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

/nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-07T23:18:41Z

Success on aarch64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

/nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-07T23:22:49Z

Failure on x86_64-darwin (full log)

Attempted: ripgrep

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `ripgrep`.

To learn more, run the command again with --verbose.
builder for '/nix/store/f7kmxd0h0f2r13qyd1sdkg08c0rx6id6-ripgrep-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/f7kmxd0h0f2r13qyd1sdkg08c0rx6id6-ripgrep-0.10.0.drv' failed

xeji · 2018-09-07T23:25:39Z

darwin failure is a regression. Security framework is missing, just do a rg Security for examples 😄

GrahamcOfBorg · 2018-09-08T10:41:23Z

Success on x86_64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

post-installation fixup
moving /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/man to /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
shrinking /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin/rg
gzipping man pages under /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
checking for references to /build in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0...
/nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-08T10:44:25Z

Success on aarch64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

post-installation fixup
moving /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/man to /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0
shrinking /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/bin/rg
gzipping man pages under /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0
checking for references to /build in /nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0...
/nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0

xeji · 2018-09-08T12:08:41Z

Let's try darwin again. Unfortunately we cannot tell ofborg to only build one platform...
@GrahamcOfBorg build ripgrep

GrahamcOfBorg · 2018-09-08T12:09:15Z

Success on aarch64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

/nix/store/m3jc9zyzcaa96sl6rskd4iy28n38gvh7-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-08T12:13:34Z

Success on x86_64-darwin (full log)

Attempted: ripgrep

Partial log (click to expand)

test result: ok. 186 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
moving /nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0/man to /nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0/share/man
gzipping man pages under /nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0
/nix/store/ms34lz0za59c8s5djbrz7i2qm61c93g0-ripgrep-0.10.0

GrahamcOfBorg · 2018-09-08T12:19:31Z

Success on x86_64-linux (full log)

Attempted: ripgrep

Partial log (click to expand)

post-installation fixup
moving /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/man to /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
shrinking /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin/rg
gzipping man pages under /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0/bin
patching script interpreter paths in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0
checking for references to /build in /nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0...
/nix/store/6zppmvi9vi5nps8p0wz06y82mw0rqwy9-ripgrep-0.10.0

xeji · 2018-09-08T12:21:15Z

Thank you! (this is my favorite search tool)

dywedir commented Sep 7, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2018

dywedir force-pushed the ripgrep branch from ca275e3 to a018f2f Compare September 8, 2018 10:22

ripgrep: 0.9.0 -> 0.10.0

927af60

dywedir force-pushed the ripgrep branch from a018f2f to 927af60 Compare September 8, 2018 10:26

dywedir mentioned this pull request Sep 8, 2018

ripgrep just released version 0.10.0 #46350

Closed

xeji merged commit 3b4ab85 into NixOS:master Sep 8, 2018

dywedir deleted the ripgrep branch September 8, 2018 12:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ripgrep: 0.9.0 -> 0.10.0 #46331

ripgrep: 0.9.0 -> 0.10.0 #46331

dywedir commented Sep 7, 2018 •

edited

dywedir Sep 7, 2018 •

edited

xeji Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

xeji commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

xeji commented Sep 7, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

xeji commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

xeji commented Sep 8, 2018

ripgrep: 0.9.0 -> 0.10.0 #46331

ripgrep: 0.9.0 -> 0.10.0 #46331

Conversation

dywedir commented Sep 7, 2018 • edited

Things done

dywedir Sep 7, 2018 • edited

Choose a reason for hiding this comment

xeji Sep 7, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

xeji commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

GrahamcOfBorg commented Sep 7, 2018

xeji commented Sep 7, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

xeji commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

xeji commented Sep 8, 2018

dywedir commented Sep 7, 2018 •

edited

dywedir Sep 7, 2018 •

edited