Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteToMessage should take non-const references, not not_null<> pointers #1929

Closed
pleroy opened this issue Sep 7, 2018 · 1 comment
Closed

Comments

@pleroy
Copy link
Member

pleroy commented Sep 7, 2018

No description provided.

@pleroy
Copy link
Member Author

pleroy commented Mar 29, 2020

Probably not a good idea, because the proto API doesn't have a selector that returns a non-const reference. Passing *x.mutable_y() doesn't look like an improvement over x->mutable_y().

@pleroy pleroy closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant