cryptsetup: enable and fix tests #46346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be backported to 18.09 |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: cryptsetup Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cryptsetup Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: cryptsetup Partial log (click to expand)
|
Mic92
reviewed
Sep 8, 2018
| --replace 'RUN "F" $1 read_buffer $((BSIZE-1))' "" \ | ||
| --replace 'RUN "F" $1 read_buffer $((BSIZE+1))' "" \ | ||
| --replace 'RUN "F" $1 write_buffer $((BSIZE-1))' "" \ | ||
| --replace 'RUN "F" $1 write_buffer $((BSIZE+1))' "" |
There was a problem hiding this comment.
Maybe a patch for this one? Otherwise it is hard to see, if this file needs an update or not (if new tests are added or fail in the sandbox).
Some tests use O_DIRECT which is filesystem dependent and fails in a sandbox as well as on some filesystems without sandboxing. Patch out O_DIRECT and disable the 4 test cases that still fail in a sandbox. See discussion in NixOS#46151.
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: cryptsetup Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cryptsetup Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: cryptsetup Partial log (click to expand)
|
|
Yep, can confirm this works. LGTM.
Thanks for getting to the bottom of this!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some tests use O_DIRECT which is filesystem dependent and fails in a sandbox as well as on some filesystems (btrfs, zfs) without sandboxing. The tests pass when run on an ext4 fs. Tests making implicit assumptions on the underlying fs aren't really useful. (I'll open an upstream issue about that).
Patch out O_DIRECT and disable the 4 test cases that still fail in a sandbox. See discussion in #46151.
Closes #46151.
Things done
--
cc @Mic92 @oxij