Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn: 20180423 -> 20180830 #46328

Merged
merged 1 commit into from Sep 14, 2018
Merged

gn: 20180423 -> 20180830 #46328

merged 1 commit into from Sep 14, 2018

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Sep 7, 2018 •
edited

gn sources have been moved into separate repository which greatly
simplify build process.

Motivation for this change

We need to update gn to build latest Chromium.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

On macOS I can't build this with sandbox as it links with system frameworks, so built w/o sandbox.

CC @stesie @matthewbauer

@YorikSar
gn: 20180423 -> 20180830
55d8a53 
gn sources have been moved into separate repository which greatly
simplify build process.
@YorikSar YorikSar mentioned this pull request Sep 7, 2018
Merged
9 tasks
YorikSar added a commit to YorikSar/nixpkgs that referenced this pull request Sep 8, 2018
@YorikSar
chromium: 68.0.3440.75 -> 69.0.3497.81 (18.03 backport)
ab193a6 
Import latest gn from NixOS#46328, just from Chromium build, since it will
trigger huge rebuild otherwise.
@YorikSar YorikSar mentioned this pull request Sep 8, 2018
Merged
9 tasks
@YorikSar
Copy link
Contributor Author

@bendlas @7c6f434c @vcunat As this is related to Chromium and you usually help with review there, could you please help out here as well?

@7c6f434c 7c6f434c merged commit 3aeb606 into NixOS:master Sep 14, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gn.src

Partial log (click to expand)

these paths will be fetched (22.74 MiB download, 27.26 MiB unpacked):
  /nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823
copying path '/nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823' from 'https://cache.nixos.org'...
/nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gn.src

Partial log (click to expand)

these paths will be fetched (22.74 MiB download, 27.26 MiB unpacked):
  /nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823
copying path '/nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823' from 'https://cache.nixos.org'...
/nix/store/bfggijdvjp9fmj68dk73w606gj5lcgmh-gn-106b823

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gn

Partial log (click to expand)

these paths will be fetched (0.74 MiB download, 2.42 MiB unpacked):
  /nix/store/9cdn4j6f1i3iw3zinljkrnpva4z6l88s-gn-20180830
copying path '/nix/store/9cdn4j6f1i3iw3zinljkrnpva4z6l88s-gn-20180830' from 'https://cache.nixos.org'...
/nix/store/9cdn4j6f1i3iw3zinljkrnpva4z6l88s-gn-20180830

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gn

Partial log (click to expand)

these paths will be fetched (0.64 MiB download, 2.08 MiB unpacked):
  /nix/store/vi35n3qzgwrzb4srlhrzym7ih02qcns1-gn-20180830
copying path '/nix/store/vi35n3qzgwrzb4srlhrzym7ih02qcns1-gn-20180830' from 'https://cache.nixos.org'...
/nix/store/vi35n3qzgwrzb4srlhrzym7ih02qcns1-gn-20180830

@YorikSar YorikSar mentioned this pull request Sep 15, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorikSar @GrahamcOfBorg @7c6f434c