Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 68.0.3440.106 -> 69.0.3497.81 #46348

Merged
merged 1 commit into from Sep 8, 2018
Merged

chromium: 68.0.3440.106 -> 69.0.3497.81 #46348

merged 1 commit into from Sep 8, 2018

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Sep 7, 2018

Also update to build with external gn.

Motivation for this change

Chromium 69 is out, with new looks and 40 security fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @vcunat @bendlas @7c6f434c

@YorikSar
chromium: 68.0.3440.106 -> 69.0.3497.81
c098f14 
Also update to build with external gn.
@YorikSar
Copy link
Contributor Author

YorikSar commented Sep 7, 2018

Note that it is currently build with older version of gn that is currently in packages (and it works), I've posted gn update at #46328 but it looks like we can backport without it.

@7c6f434c 7c6f434c merged commit 7c69ae6 into NixOS:master Sep 8, 2018
vcunat pushed a commit that referenced this pull request Sep 8, 2018
@7c6f434c @vcunat
Merge #46348: chromium: 68.0.3440.106 -> 69.0.3497.81
f890192 
(cherry picked from commit 7c69ae6)
@vcunat
Copy link
Member

vcunat commented Sep 8, 2018

For 18.03 this won't build if cherry-picked directly, unless I did something wrong during conflict resolution.

  configuring
  ERROR at //ui/events/BUILD.gn:80:12: Assignment had no effect.
    friend = [ ":*" ]
             ^------
  You set the variable "friend" here and it was unused before it went
  out of scope.
  See //BUILD.gn:211:7: which caused the file to be included.
        "//ui/events:events_unittests",
        ^-----------------------------

(security fixes means we probably should do it)

@vcunat vcunat added 9.needs: port to stable A PR needs a backport to the stable release. 1.severity: security labels Sep 8, 2018
@YorikSar
Copy link
Contributor Author

YorikSar commented Sep 8, 2018

@vcunat I've ran into same issue, investigating it.

@YorikSar
Copy link
Contributor Author

YorikSar commented Sep 8, 2018

@vcunat the problem is in gn version. Sad thing is that if we backport changes to it, it'll trigger huge rebuild. Will it be ok if we import newer gn just for chromium?

@YorikSar YorikSar mentioned this pull request Sep 8, 2018
Merged
9 tasks
@YorikSar
Copy link
Contributor Author

YorikSar commented Sep 8, 2018

Posted new PR with backport with new private gn version.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@YorikSar YorikSar deleted the update-chromium branch June 8, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YorikSar @vcunat @samueldr @7c6f434c @GrahamcOfBorg