Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.trio: fix build #46342

Merged
merged 1 commit into from Sep 7, 2018
Merged

pythonPackages.trio: fix build #46342

merged 1 commit into from Sep 7, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 7, 2018 •
edited

Motivation for this change

Fixes the build for `python3Packages.trio' for the next ZHF iteration.
Please refer to the Hydra build for further reference: https://hydra.nixos.org/build/80617356

python3Packages.sniffio is needed for the build, otherwise the build
aborts with an error like this:

  Could not find a version that satisfies the requirement sniffio (from trio==0.6.0) (from versions: )
No matching distribution found for sniffio (from trio==0.6.0)

See #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.trio: fix build
a38b374 
Fixes the build for `python3Packages.trio' for the next ZHF iteration.
Please refer to the Hydra build for further reference: https://hydra.nixos.org/build/80617356

`python3Packages.sniffio` is needed for the build, otherwise the build
aborts with an error like this:

```
  Could not find a version that satisfies the requirement sniffio (from trio==0.6.0) (from versions: )
No matching distribution found for sniffio (from trio==0.6.0)
```

See NixOS#45960
@Ma27 Ma27 requested a review from FRidh as a code owner September 7, 2018 21:01
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@GrahamcOfBorg build python36Packages.trio

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.trio

Partial log (click to expand)

trio/tests/test_ssl.py ............................                      [ 74%]
trio/tests/test_sync.py .......................................          [ 82%]
trio/tests/test_testing.py ........................                      [ 87%]
trio/tests/test_threads.py .......................                       [ 92%]
trio/tests/test_timeouts.py ...                                          [ 93%]
trio/tests/test_util.py ..........................                       [ 99%]
trio/tests/test_wait_for_object.py ssss                                  [100%]

============ 456 passed, 10 skipped, 3 deselected in 16.14 seconds =============
/nix/store/ldbbfs2wrf3bphsnapzb376mjnw5azk7-python3.6-trio-0.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.trio

Partial log (click to expand)

trio/tests/test_ssl.py ............................                      [ 74%]
trio/tests/test_sync.py .......................................          [ 82%]
trio/tests/test_testing.py ........................                      [ 87%]
trio/tests/test_threads.py .......................                       [ 92%]
trio/tests/test_timeouts.py ...                                          [ 93%]
trio/tests/test_util.py ..........................                       [ 99%]
trio/tests/test_wait_for_object.py ssss                                  [100%]

============= 457 passed, 9 skipped, 3 deselected in 14.46 seconds =============
/nix/store/m62w0f01b8cm099qbb5lx9dxly4qkb0b-python3.6-trio-0.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.trio

Partial log (click to expand)

trio/tests/test_ssl.py ............................                      [ 74%]
trio/tests/test_sync.py .......................................          [ 82%]
trio/tests/test_testing.py ........................                      [ 87%]
trio/tests/test_threads.py .......................                       [ 92%]
trio/tests/test_timeouts.py ...                                          [ 93%]
trio/tests/test_util.py ..........................                       [ 99%]
trio/tests/test_wait_for_object.py ssss                                  [100%]

============= 457 passed, 9 skipped, 3 deselected in 47.70 seconds =============
/nix/store/snxqgqgbqbalbiq2pdn850gg5i9cnvqb-python3.6-trio-0.6.0

@xeji xeji merged commit 218ac50 into NixOS:master Sep 7, 2018
xeji pushed a commit that referenced this pull request Sep 7, 2018
@Ma27 @xeji
pythonPackages.trio: fix build (#46342)
0842915 
Fixes the build for `python3Packages.trio' for the next ZHF iteration.
Please refer to the Hydra build for further reference: https://hydra.nixos.org/build/80617356

`python3Packages.sniffio` is needed for the build, otherwise the build
aborts with an error like this:

```
  Could not find a version that satisfies the requirement sniffio (from trio==0.6.0) (from versions: )
No matching distribution found for sniffio (from trio==0.6.0)
```

See #45960

(cherry picked from commit 218ac50)
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

backported: 0842915

@Ma27 Ma27 deleted the fix-python-trio branch September 7, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg