Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: fix quoting for ${} syntax #46324

Merged
merged 1 commit into from Sep 7, 2018
Merged

weechat: fix quoting for ${} syntax #46324

merged 1 commit into from Sep 7, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 7, 2018 •
edited

Motivation for this change

In my previous PR I missed that ${sec.foobar} (syntax to retrieve
secrets in a weechat runtime) breaks the shell evaluation.

Furthermore ; shall be used rather than \n to concat scripts and the
init config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
weechat: fix quoting for ${} syntax
e2b4644 
In my previous PR I missed that ${sec.foobar} (syntax to retrieve
secrets in a weechat runtime) breaks the shell evaluation.

Furthermore `;` shall be used rather than `\n` to concat scripts and the
init config.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat

Partial log (click to expand)

these derivations will be built:
  /nix/store/6wkzhkbg40637xp1xpx73dx02fkj1j07-weechat.drv
  /nix/store/rcyfnqsaj9drf8l4bs5f08ww06hfxn78-weechat-headless.drv
  /nix/store/166a59padphsrlm0d3nxajwn6479j0y0-weechat-bin-env.drv
building '/nix/store/rcyfnqsaj9drf8l4bs5f08ww06hfxn78-weechat-headless.drv'...
building '/nix/store/6wkzhkbg40637xp1xpx73dx02fkj1j07-weechat.drv'...
building '/nix/store/166a59padphsrlm0d3nxajwn6479j0y0-weechat-bin-env.drv'...
created 2 symlinks in user environment
/nix/store/5n5kbsabvbijddpc76h1n8r9s4sqsh5r-weechat-bin-env

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/99z7irnlshqrn9c9326y5hggpfn080g7-weechat-2.2-perl' from 'https://cache.nixos.org'...
copying path '/nix/store/ncgf7b9c9iiflw8qngi2argvl749zr13-weechat-2.2-python' from 'https://cache.nixos.org'...
copying path '/nix/store/2rdfxb7y5c5dh702lsdhmnbay7rc6i1i-weechat-2.2-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/sr1fvic96g9a3wdc4yh63fw3v61fgiyw-weechat-2.2-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/ki52hv6gf7720wn159hlh5pa0bwmyisz-weechat-plugins' from 'https://cache.nixos.org'...
building '/nix/store/jk9hfvkrgv31xcfhpz1fbcfqj827cpam-weechat-headless.drv'...
building '/nix/store/zd4db8cfk47afqh5s38g751h6qrzhpn9-weechat.drv'...
building '/nix/store/3bsdvpzzqv5qj4n45f16jja7sabc9c7q-weechat-bin-env.drv'...
created 2 symlinks in user environment
/nix/store/0s6v46blxdg7lkqakn6zaikac6in8qj5-weechat-bin-env

@timokau timokau merged commit c04198a into NixOS:master Sep 7, 2018
@timokau timokau mentioned this pull request Sep 7, 2018
Merged
9 tasks
@Ma27 Ma27 deleted the weechat-script-fixes branch September 7, 2018 17:05
@Ma27
Copy link
Member Author

Ma27 commented Sep 7, 2018

thanks and sorry for that 😅

@timokau
Copy link
Member

timokau commented Sep 7, 2018

Well I was the reviewer, so its my fault at least as much as yours :) No harm done, easy mistake to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @timokau