Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2018.08.28 -> 2018.09.01, fix youtube download #46332

Merged
merged 2 commits into from Sep 7, 2018
Merged

youtube-dl: 2018.08.28 -> 2018.09.01, fix youtube download #46332

merged 2 commits into from Sep 7, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 7, 2018 •
edited

Motivation for this change

Youtube made an update that breaks youtube-dl on many videos. Since that is a big breakage for many users (for example those using mpv to stream youtube), we should include the fix (unmerged upstream PR ytdl-org/youtube-dl#17464) as soon as possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 7, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.9.1
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01
gzipping man pages under /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/lib  /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01
checking for references to /build in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01...
wrapping `/nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: youtube-dl

Partial log (click to expand)

  The script youtube-dl is installed in '/nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed youtube-dl-2018.9.1
/private/tmp/nix-build-python3.6-youtube-dl-2018.09.01.drv-0/youtube-dl
post-installation fixup
gzipping man pages under /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/lib  /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01
wrapping `/nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.9.1
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01
gzipping man pages under /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/lib  /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01
checking for references to /build in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01...
wrapping `/nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...

@timokau timokau merged commit 89ef631 into NixOS:master Sep 7, 2018
@timokau timokau added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 7, 2018
@timokau timokau deleted the youtube-dl-fix branch September 7, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg