Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-helm: fix darwin hash #46338

Merged
merged 1 commit into from Sep 7, 2018
Merged

kubernetes-helm: fix darwin hash #46338

merged 1 commit into from Sep 7, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Sep 7, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: kubernetes-helm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

100 8991k  100 8991k    0     0  40.8M      0 --:--:-- --:--:-- --:--:-- 40.8M
copying path '/nix/store/mr5kxi7w6vk9yhkhrdx08g52rm0r5gbm-kubectl-1.10.5' from 'https://cache.nixos.org'...
building '/nix/store/7sskz039zy2aghkm2bcjqwcgf6gy4y09-helm-2.10.0.drv'...
building
installing
linux-amd64/
linux-amd64/LICENSE
linux-amd64/helm
linux-amd64/README.md
/nix/store/iz6lgd08ycc0iggn2zsjl7v19pvvbhb6-helm-2.10.0

@rasendubi
Copy link
Member

Not sure why the hash has changed but I confirm it is 1l8y9i8vhibhwbn5kn5qp722q4dcx464kymlzy2bkmhiqbxnnkkw indeed.

rasen@omicron ~> nix-prefetch-url https://kubernetes-helm.storage.googleapis.com/helm-v2.10.0-darwin-amd64.tar.gz
path is '/nix/store/yj20cdhjr08nqryhh76vwhqjrr6a8lp6-helm-v2.10.0-darwin-amd64.tar.gz'
1l8y9i8vhibhwbn5kn5qp722q4dcx464kymlzy2bkmhiqbxnnkkw

@nlewo
Copy link
Member Author

nlewo commented Sep 7, 2018

@rahulgopinath It has changed because the version has been upgraded in the PR #46256. I've merged it a bit too quickly (focused on x86 :/).

@rasendubi
Copy link
Member

@GrahamcOfBorg build kubernetes-helm

Hope it'll check darwin, too :)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

/nix/store/iz6lgd08ycc0iggn2zsjl7v19pvvbhb6-helm-2.10.0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: kubernetes-helm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

these derivations will be built:
  /nix/store/bkh3wcwrrb0ln0p6bvw084f148xvgjkx-helm-2.10.0.drv
building '/nix/store/bkh3wcwrrb0ln0p6bvw084f148xvgjkx-helm-2.10.0.drv'...
building
installing
darwin-amd64/
darwin-amd64/LICENSE
darwin-amd64/helm
darwin-amd64/README.md
/nix/store/4naxijwq4wvkzj3d2srzbq3gf9ry12br-helm-2.10.0

@nlewo
Copy link
Member Author

nlewo commented Sep 7, 2018 •
edited

@rasendubi yep, I was waiting for this too. So it seems good now. Thx.

@nlewo nlewo merged commit 248eb0f into NixOS:master Sep 7, 2018
@rasendubi
Copy link
Member

@nlewo you might want to add yourself to the trusted users: https://github.com/NixOS/ofborg#trusted-users-vs-known-users

@nlewo
Copy link
Member Author

nlewo commented Sep 7, 2018

@rasendubi I wasn't aware of this. I'll then add myself. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @GrahamcOfBorg @rasendubi