Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-applications: 18.04.03 -> 18.08.0 #45376

Merged
merged 2 commits into from Aug 25, 2018
Merged

kde-applications: 18.04.03 -> 18.08.0 #45376

merged 2 commits into from Aug 25, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Aug 20, 2018 •
edited

Motivation for this change

There is currently a linker error in dolphin, that I could only circumvent by reverting a patch. I already opened a bug report upstream: https://bugs.kde.org/show_bug.cgi?id=397653
Hopefully, this will come to a better solution.

Maybe someone with more knowledge about cmake and NixOS, has an idea why PRIVATE does not work.

@adisbladis @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner August 20, 2018 11:46
@peterhoeg
Copy link
Member

Couple of minor things:

  1. dolphin.patch is not particularly descriptive
  2. Please link to the upstream bug inside dophin.nix to make things easy for the next guy

@bkchr
Copy link
Contributor Author

bkchr commented Aug 20, 2018

Yeah, I hope that I can remove that before merging.

@bkchr
Copy link
Contributor Author

bkchr commented Aug 23, 2018

I could remove the patch, the package required cmakeFlags = [ "-DCMAKE_SKIP_BUILD_RPATH=OFF" ];, so that we have the correct RPATH while building.

@bkchr bkchr force-pushed the kde_applications_18_08_0 branch 2 times, most recently from a85c1e5 to b2f881f Compare August 23, 2018 22:12
@ttuegel ttuegel merged commit b55e3f6 into NixOS:master Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @peterhoeg @ttuegel @GrahamcOfBorg