Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facette: 0.4.0 -> 0.4.1 #45372

Merged
merged 2 commits into from Aug 20, 2018
Merged

facette: 0.4.0 -> 0.4.1 #45372

merged 2 commits into from Aug 20, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Aug 20, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Aug 20, 2018

@GrahamcOfBorg build facette

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: facette

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: facette

Partial log (click to expand)

npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/npm-1000/.npm/_logs/2018-08-20T09_49_17_946Z-debug.log
result: fail
make: *** [Makefile:153: node_modules] Error 1
builder for '/nix/store/xr50yxa2ca2yfcasdzgqwlr4z28d9m1w-facette-0.4.1.drv' failed with exit code 2
error: build of '/nix/store/xr50yxa2ca2yfcasdzgqwlr4z28d9m1w-facette-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: facette

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: facette

Partial log (click to expand)

npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/npm-1000/.npm/_logs/2018-08-20T10_00_05_861Z-debug.log
result: fail
make: *** [Makefile:153: node_modules] Error 1
builder for '/nix/store/xr50yxa2ca2yfcasdzgqwlr4z28d9m1w-facette-0.4.1.drv' failed with exit code 2
error: build of '/nix/store/xr50yxa2ca2yfcasdzgqwlr4z28d9m1w-facette-0.4.1.drv' failed

@fgaz fgaz mentioned this pull request Aug 20, 2018
Closed
@fgaz
Copy link
Member Author

fgaz commented Aug 20, 2018

Right... this requires an itnernet connection to build, which is why we don't have facette cached in nixpkgs :-/

@Mic92
Copy link
Member

Mic92 commented Aug 20, 2018 •
edited

Can you get the compiled assets from the release tarball? https://github.com/facette/facette/releases
Otherwise we should mark this package as broken.

@fgaz
Copy link
Member Author

fgaz commented Aug 20, 2018

I just marked it as broken for now

@fgaz
Copy link
Member Author

fgaz commented Aug 20, 2018

I'll open an issue about the assets and fix it later

@fgaz
facette: mark as broken since it requires internet
0e0e963 
It _is_ buildable, just not without an internet connection (like in hydra)
@Mic92 Mic92 merged commit a4869cb into NixOS:master Aug 20, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: facette

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: facette

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@fgaz fgaz deleted the facette/0.4.0-0.4.1 branch August 20, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @GrahamcOfBorg @Mic92