Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilix: 1.8.1 -> 1.8.3 #45379

Merged
merged 1 commit into from Aug 20, 2018
Merged

tilix: 1.8.1 -> 1.8.3 #45379

merged 1 commit into from Aug 20, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

Update to newest version of tilix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tilix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: tilix

Partial log (click to expand)


Total Test time (real) =  43.25 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
checking for references to /build in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0...
warning: path '/nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0' claims to be content-addressed but isn't
error: unexpected end-of-file

@Mic92
Copy link
Member

Mic92 commented Aug 20, 2018 

$ tilix
Library libsecret-1.so.0 cannot be loaded, related functionality will not be available

it probably wants libsecret in its LD_LIBRARY_PATH.

@ThomasMader
Copy link
Contributor Author

Yes, libsecret is an optional dependency.
I added libsecret to the LD_LIBRARY_PATH.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tilix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tilix

Partial log (click to expand)

Wrapping program /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3/bin/tilix
Wrapping program /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3/bin/.tilix-wrapped
shrinking RPATHs of ELF executables and libraries in /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3
shrinking /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3/bin/..tilix-wrapped-wrapped
gzipping man pages under /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3/bin
patching script interpreter paths in /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3
checking for references to /build in /nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3...
/nix/store/5h65llhsm2l1lp63wa70zfdv7jixg20w-tilix-1.8.3

@Mic92 Mic92 merged commit 8158297 into NixOS:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThomasMader @GrahamcOfBorg @Mic92