Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vdemeester (myself) as runc and containerd package maintainer #45384

Conversation

vdemeester
Copy link
Member

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Adding myself as maintainer for runc and containerd as I happen to work a bit on those project and the maintainer list is a bit short #45241 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92 @ryantm

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@Mic92 Mic92 merged commit 996d76a into NixOS:master Aug 20, 2018
@vdemeester vdemeester deleted the add-vdemeester-as-containerd-and-runc-maintainers branch August 20, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants