Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.NetSFTPForeign: init at 1.89 #45380

Merged
merged 4 commits into from Aug 20, 2018
Merged

perlPackages.NetSFTPForeign: init at 1.89 #45380

merged 4 commits into from Aug 20, 2018

Conversation

aanderse
Copy link
Member

Motivation for this change

Added Net::SFTP::Foreign module from CPAN to perlPackages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Aug 20, 2018
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated
};
meta = {
description = "Secure File Transfer Protocol client";
license = stdenv.lib.licenses.unknown;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown is not a valid value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that. Not sure why nix-generate-from-cpan missed the license this time. Fixed.

@Mic92 Mic92 merged commit 35b8140 into NixOS:master Aug 20, 2018
@aanderse aanderse deleted the net-sftp-foreign branch August 20, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Mic92 @GrahamcOfBorg