Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmdk: init at 1.4.1 #45381

Closed
wants to merge 1 commit into from
Closed

pmdk: init at 1.4.1 #45381

wants to merge 1 commit into from

Conversation

barakb
Copy link

@barakb barakb commented Aug 20, 2018

pmdk is a persistent memory development kit

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@barakb
pmdk: init at 1.4.1
95c81c4 
pmdk is a persistent memory development kit
srhb
srhb requested changes Aug 21, 2018
View reviewed changes
pkgs/development/libraries/pmdk/default.nix
homepage = https://pmem.io/pmdk;
license = licenses.bsd3;
platforms = platforms.unix;
maintainers = [ maintainers.barakb ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these live in stdenv.lib: stdenv.lib.licenses.bsd3, stdenv.lib.platforms.unix, stdenv.lib.maintainers.barakb

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@yorickvP
Copy link
Contributor

yorickvP commented Dec 4, 2019

added in #59093

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/87

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/76

@timokau timokau closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb requested changes

Assignees
No one assigned
Labels
2.status: merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@barakb @mmahut @yorickvP @nixos-discourse @srhb @samueldr @timokau