Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some substitutions for the ip calls in ManagedRoutes. Fixes #45022 #45391

Merged
merged 1 commit into from Aug 21, 2018

Conversation

commandodev
Copy link
Contributor

@commandodev commandodev commented Aug 20, 2018

Fixes #45022 Superceeds #45383

Motivation for this change

Manged routes aren't being created

Things done

Pulled in and fixed a change from @zimbatm in #45383 and also caught another instance. I've tested this in a nixos module pointing at a zerotier network with a managed route that wasn't visible in the routing table before this change and now is.


@grahamc
Copy link
Member

grahamc commented Aug 21, 2018

@GrahamcOfBorg build zerotierone

@zimbatm zimbatm merged commit c28898d into NixOS:master Aug 21, 2018
@grahamc
Copy link
Member

grahamc commented Aug 21, 2018

@Boothead Can you update your commit message to start with zerotierone: ? If not, I can take care of that for you.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zerotierone

Partial log (click to expand)

strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sdzyd6slcwy3i98zmpjaz7z5kk2lr6kg-zerotierone-1.2.12/bin
patching script interpreter paths in /nix/store/sdzyd6slcwy3i98zmpjaz7z5kk2lr6kg-zerotierone-1.2.12
checking for references to /build in /nix/store/sdzyd6slcwy3i98zmpjaz7z5kk2lr6kg-zerotierone-1.2.12...
shrinking RPATHs of ELF executables and libraries in /nix/store/j0nxgrf6xpza6acqn0pwwrl9hjihc325-zerotierone-1.2.12-man
gzipping man pages under /nix/store/j0nxgrf6xpza6acqn0pwwrl9hjihc325-zerotierone-1.2.12-man/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/j0nxgrf6xpza6acqn0pwwrl9hjihc325-zerotierone-1.2.12-man
checking for references to /build in /nix/store/j0nxgrf6xpza6acqn0pwwrl9hjihc325-zerotierone-1.2.12-man...
/nix/store/sdzyd6slcwy3i98zmpjaz7z5kk2lr6kg-zerotierone-1.2.12

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zerotierone

Partial log (click to expand)

strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c6x83hawvqlprr6b4w58r8vhcsykgmmm-zerotierone-1.2.12/bin
patching script interpreter paths in /nix/store/c6x83hawvqlprr6b4w58r8vhcsykgmmm-zerotierone-1.2.12
checking for references to /build in /nix/store/c6x83hawvqlprr6b4w58r8vhcsykgmmm-zerotierone-1.2.12...
shrinking RPATHs of ELF executables and libraries in /nix/store/2bnv19r57r17a2xaixk9aj5ydkz11mk6-zerotierone-1.2.12-man
gzipping man pages under /nix/store/2bnv19r57r17a2xaixk9aj5ydkz11mk6-zerotierone-1.2.12-man/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2bnv19r57r17a2xaixk9aj5ydkz11mk6-zerotierone-1.2.12-man
checking for references to /build in /nix/store/2bnv19r57r17a2xaixk9aj5ydkz11mk6-zerotierone-1.2.12-man...
/nix/store/c6x83hawvqlprr6b4w58r8vhcsykgmmm-zerotierone-1.2.12

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: zerotierone

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zerotier doesn't add managed routes
4 participants