Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit-tmpdir: fix processing of files with spaces, quote variables #45396

Merged
merged 1 commit into from Aug 21, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 20, 2018

Noticed errors invoking "dirname" and "basename" in my build logs
while packaging and tracked the problem back to this location.

Quote variable when expanding like is done elsewhere in the script.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Aug 21, 2018

Alright well it's worked well for me, and looks like folks approve :). Here we go!

@dtzWill dtzWill merged commit 9c35796 into NixOS:staging Aug 21, 2018
@dtzWill dtzWill deleted the fix/audit-tmpdir-quote branch August 21, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants