Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apmplanner2: init at 2.0.26 #45305

Merged
merged 1 commit into from Aug 23, 2018
Merged

apmplanner2: init at 2.0.26 #45305

merged 1 commit into from Aug 23, 2018

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Aug 18, 2018 •
edited by matthewbauer

Motivation for this change

I would like to see more Ground Control Stations in the nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Aug 19, 2018
View reviewed changes
pkgs/applications/science/robotics/apmplanner2/default.nix
src = fetchFromGitHub {
owner = "ArduPilot";
repo = "apm_planner";
rev = "${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unnecessary string interpolation here, could be simply rev = version.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build apmplanner2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: apmplanner2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apmplanner2

Partial log (click to expand)

strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26/bin
patching script interpreter paths in /nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26
/nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/Rascal/Models/fix.sh: interpreter directive changed from " /bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/Rascal110/Models/fix.sh: interpreter directive changed from " /bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/arducopter/formatXml.sh: interpreter directive changed from "/bin/bash" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26...
postPatchMkspecs
postPatchMkspecs
/nix/store/i2qnwvnbac52lfvsrq5frwhn98awg59j-apmplanner2-2.0.26

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apmplanner2

Partial log (click to expand)

strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26/bin
patching script interpreter paths in /nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26
/nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/Rascal110/Models/fix.sh: interpreter directive changed from " /bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/arducopter/formatXml.sh: interpreter directive changed from "/bin/bash" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/bash"
/nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26/share/APMPlanner2/files/flightgear/Aircraft/Rascal/Models/fix.sh: interpreter directive changed from " /bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26...
postPatchMkspecs
postPatchMkspecs
/nix/store/0fvamg1yxlbsq6qlicpygjhdwrqdzcqx-apmplanner2-2.0.26

@wucke13
apmplanner2: init at 2.0.26
b453160 
I would like to see more Ground Control Stations in the nixpkgs.
@wucke13
Copy link
Contributor Author

wucke13 commented Aug 21, 2018

@joachifm
Thanks for the feedback. I adjusted accordingly.

@joachifm joachifm merged commit 0d80f96 into NixOS:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wucke13 @joachifm @GrahamcOfBorg