Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgpack: rename from libmsgpack #45284

Merged
merged 1 commit into from Aug 19, 2018
Merged

msgpack: rename from libmsgpack #45284

merged 1 commit into from Aug 19, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Aug 18, 2018

Motivation for this change

The project does not use the name "libmsgpack". It variously uses "msgpack" and
"msgpack-c", and "msgpackc" for the name of the library.

This should be merged after #45283.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej orivej requested a review from zimbatm as a code owner August 18, 2018 00:02
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5
shrinking /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/libmsgpackc.so.2.0.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5
checking for references to /build in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5
shrinking /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/libmsgpackc.so.2.0.0
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5
checking for references to /build in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/include/msgpack/zone_decl.hpp
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/pkgconfig/msgpack.pc
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

still it needs to rebased.

@orivej
msgpack: rename from libmsgpack
65663f8 
The project does not use the name "libmsgpack". It variously uses "msgpack" and
"msgpack-c", and "msgpackc" for the name of the library.
@orivej
Copy link
Contributor Author

orivej commented Aug 18, 2018

Thanks! Rebased.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1
shrinking /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1
checking for references to /build in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/include/msgpack/zone_decl.hpp
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/pkgconfig/msgpack.pc
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: msgpack

Partial log (click to expand)

-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1
shrinking /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1
checking for references to /build in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1...

@Mic92 Mic92 merged commit cfe738b into NixOS:master Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @Mic92