dragon: init at 18.04.3 #45315
Merged
dragon: init at 18.04.3 #45315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Dragon Player, the KDE video and media player, so that KDE users will have a way to play videos and audio files.
adisbladis
reviewed
Aug 19, 2018
pkgs/applications/kde/dragon.nix
Outdated
| meta = { | ||
| license = with lib.licenses; [ gpl2 fdl12 ]; | ||
| description = "A simple media player for KDE"; | ||
| maintainers = [ lib.maintainers.ttuegel ]; |
There was a problem hiding this comment.
You probably don't want to add @ttuegel as a maintainer :)
There was a problem hiding this comment.
You're probably right. That was just copypasta. Do I add myself as a maintainer, and add that to this PR?
There was a problem hiding this comment.
Just added myself as maintainer, and changed this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dragon Player, the KDE video and media player, so that KDE
users will have a way to play videos and audio files.
Motivation for this change
There is currently no video/media player for KDE in the Nixpkgs repos. However, the mechanism for sourcing the application is already provided by the KDE infrastructure in nixpkgs. So this just makes a formal package out of it, so that KDE users can play videos out-of-the-box.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)