Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses #45282

Merged
merged 20 commits into from Aug 19, 2018
Merged

Add licenses #45282

merged 20 commits into from Aug 19, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Another round for #43716

Things done

Added license tags to:

  • xfig
  • systemd
  • shadow
  • pptp
  • ppp
  • polkit
  • perl
  • openssl
  • openldap
  • nss_ldap
  • nss
  • mktemp
  • mingetty
  • man-pages
  • mdadm
  • lvm2
  • lsscsi
  • libressl
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Aug 18, 2018
View reviewed changes
pkgs/development/interpreters/perl/default.nix Outdated
@@ -152,6 +152,7 @@ let
meta = {
homepage = https://www.perl.org/;
description = "The standard implementation of the Perl 5 programmming language";
license = licenses.gpl1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://dev.perl.org/licenses/ you can choose gpl v1 or any later version. It is really gpl + clarifications by the author, however, so maybe consider using the Artistic License which makes those clarifications explicit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make it just make it [ gpl1Plus artistic1 ]? (Perl 6 would be artistic2?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just use Artistic, because it expresses most clearly the intent of the author, but I'm happy to leave that to your judgment.

Copy link
Contributor

@joachifm joachifm Aug 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I'd be happy to leave it as is, too, I just wanted to mention this as a potential consideration, not a blocker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see your point here. We can change it to Artistic.

@Mic92 Mic92 merged commit 96b9d77 into NixOS:master Aug 19, 2018
@markuskowa markuskowa deleted the lics-2 branch September 4, 2018 11:20
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pkgsCross.armv7l-hf-multiplatform.systemd

Partial log (click to expand)

Message: Using /nix/store/kpqhni9nriinb5zhzkc8mcgc4cvbi2g6-kbd-2.0.4-armv7l-unknown-linux-gnueabihf/bin/setfont for setfont
Program gperf found: YES (/nix/store/pnv2bsasz1a2dkmc5cyw02y71gfwx9vp-gperf-3.1/bin/gperf)
Message: gperf len type is size_t
Has header "sys/capability.h": NO

meson.build:597:8: ERROR:  Problem encountered: POSIX caps headers not found

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/fxbdh2jw5vw8mfjb48a1pav856qhf9hx-systemd-239-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 1
error: build of '/nix/store/fxbdh2jw5vw8mfjb48a1pav856qhf9hx-systemd-239-armv7l-unknown-linux-gnueabihf.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgsCross.aarch64-multiplatform.systemd

Partial log (click to expand)

gzipping man pages under /nix/store/jfnhi81lvmlx9db22niw502mgdrgg3ji-systemd-239-man/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jfnhi81lvmlx9db22niw502mgdrgg3ji-systemd-239-man
checking for references to /build in /nix/store/jfnhi81lvmlx9db22niw502mgdrgg3ji-systemd-239-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/4azwffjdvfpmcmadsw8r7i2xdr4vr3dm-systemd-239-dev
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4azwffjdvfpmcmadsw8r7i2xdr4vr3dm-systemd-239-dev/lib
patching script interpreter paths in /nix/store/4azwffjdvfpmcmadsw8r7i2xdr4vr3dm-systemd-239-dev
checking for references to /build in /nix/store/4azwffjdvfpmcmadsw8r7i2xdr4vr3dm-systemd-239-dev...
/nix/store/dnbams4hw2m3mr5b5di3g9kg3l66m3h5-systemd-239

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pkgsCross.aarch64-multiplatform.systemd

Partial log (click to expand)

Message: Using /nix/store/8x7xz76nc3jdykjhdrd408xm7i761xrs-kbd-2.0.4-aarch64-unknown-linux-gnu/bin/setfont for setfont
Program gperf found: YES (/nix/store/fjy4wlrardq8frky0cq7a71ifscgxaan-gperf-3.1/bin/gperf)
Message: gperf len type is size_t
Has header "sys/capability.h": NO

meson.build:597:8: ERROR:  Problem encountered: POSIX caps headers not found

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/yqcgb2ihfamxj08km24pjbvmhxkrvjfr-systemd-239-aarch64-unknown-linux-gnu.drv' failed with exit code 1
error: build of '/nix/store/yqcgb2ihfamxj08km24pjbvmhxkrvjfr-systemd-239-aarch64-unknown-linux-gnu.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: pkgsCross.armv7l-hf-multiplatform.systemd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/sizfrpxvgyps5c0q1kf8j5da4m8y9cvm-gnu-efi-3.0.8-armv7l-unknown-linux-gnueabihf
shrinking /nix/store/sizfrpxvgyps5c0q1kf8j5da4m8y9cvm-gnu-efi-3.0.8-armv7l-unknown-linux-gnueabihf/lib/crt0-efi-arm.o
wrong ELF type
armv7l-unknown-linux-gnueabihf-strip is /nix/store/4rvcfng3ficml932m928w9mbfqhvn54z-armv7l-unknown-linux-gnueabihf-binutils-2.30/bin/armv7l-unknown-linux-gnueabihf-strip
stripping (with command armv7l-unknown-linux-gnueabihf-strip and flags -S) in /nix/store/sizfrpxvgyps5c0q1kf8j5da4m8y9cvm-gnu-efi-3.0.8-armv7l-unknown-linux-gnueabihf/lib
patching script interpreter paths in /nix/store/sizfrpxvgyps5c0q1kf8j5da4m8y9cvm-gnu-efi-3.0.8-armv7l-unknown-linux-gnueabihf
checking for references to /build in /nix/store/sizfrpxvgyps5c0q1kf8j5da4m8y9cvm-gnu-efi-3.0.8-armv7l-unknown-linux-gnueabihf...
wrong ELF type
cannot build derivation '/nix/store/jwv7r2wn2c75qwxjq4bg80lbc9vb4l9k-systemd-239-armv7l-unknown-linux-gnueabihf.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jwv7r2wn2c75qwxjq4bg80lbc9vb4l9k-systemd-239-armv7l-unknown-linux-gnueabihf.drv' failed

@markuskowa markuskowa mentioned this pull request Oct 18, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @GrahamcOfBorg @joachifm @Mic92