Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecos: init at 2.0.6 #45292

Merged
merged 2 commits into from Aug 18, 2018
Merged

ecos: init at 2.0.6 #45292

merged 2 commits into from Aug 18, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Aug 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Aug 18, 2018

@GrahamcOfBorg build ecos

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecos

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
shrinking /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib/libecos.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
checking for references to /build in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6...
/nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6

bhipple
bhipple commented Aug 18, 2018
View reviewed changes
pkgs/development/libraries/science/math/ecos/default.nix
make test
./runecos
'';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream makefile doesn't ship a proper make check or make install, but these get the job done.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecos

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6
shrinking /nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6/lib/libecos.so
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6
checking for references to /build in /nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6...
/nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecos

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
shrinking /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib/libecos.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
checking for references to /build in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6...
/nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6

infinisil
infinisil requested changes Aug 18, 2018
View reviewed changes
pkgs/development/libraries/science/math/ecos/default.nix Outdated
homepage = https://www.embotech.com/ECOS;
license = licenses.gpl3;
maintainers = [ maintainers.bhipple ];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify platforms here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added platforms.all; this is a simple C library with no dependencies, so I'd expect it to "just work" everywhere. That said, I've only tested it on x64_64-linux (and OfBorg seems to have tested it successfully on aarch64-linux).

pkgs/development/libraries/science/math/ecos/default.nix Outdated
sha256 = "11v958j66wq30gxpjpkgl7n3rvla845lygz8fl39pgf1vk9sdyc7";
};

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is true by default

Copy link
Contributor Author

@bhipple bhipple Aug 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but it's definitely not running the checkPhase if I omit this and run nix-build . -A ecos. It defaults to true in the buildPythonPackage helper, but appears not to be true for the general stdenv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah you're right, it's false by default

@grahamc
Copy link
Member

grahamc commented Aug 18, 2018

@GrahamcOfBorg build ecos

1 similar comment
@vcunat
Copy link
Member

vcunat commented Aug 18, 2018

@GrahamcOfBorg build ecos

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ecos

Partial log (click to expand)


OPTIMAL (within feastol=7.3e-13, reltol=5.9e-09, abstol=1.1e-09).
Runtime: 0.001597 seconds.

installing
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6
/nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ecos

Partial log (click to expand)


OPTIMAL (within feastol=7.3e-13, reltol=5.9e-09, abstol=1.1e-09).
Runtime: 0.001670 seconds.

installing
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6
/nix/store/q3nwmfk18g1p9s7079mrs14g0rs9kw8x-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecos

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
shrinking /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib/libecos.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6/lib
patching script interpreter paths in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6
checking for references to /build in /nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6...
/nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1pfcl2s3y9lcg0z5174bm2qpxj0a6565-ecos-2.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecos

Partial log (click to expand)

/nix/store/1dnbzvrj17zn11lbi1z6ywl9h5h56wsp-ecos-2.0.6

@infinisil infinisil merged commit e814570 into NixOS:master Aug 18, 2018
@infinisil
Copy link
Member

Whoops, I should've squashed it

@bhipple bhipple deleted the add/ecos branch August 18, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bhipple @GrahamcOfBorg @grahamc @vcunat @infinisil @kalbasit