Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molden: 5.7 -> 5.8.2 #45303

Merged
merged 2 commits into from Aug 19, 2018
Merged

molden: 5.7 -> 5.8.2 #45303

merged 2 commits into from Aug 19, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Update version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

@GrahamcOfBorg build molden

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: molden

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

Can you add yourself to https://github.com/NixOS/ofborg ?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: molden

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: molden

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@markuskowa
Copy link
Member Author

Yes! Thanks for the tip. I guess I have to add myself to the list of users and open a pull request?

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

yes.

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

I get an error when building this in Linux: https://gist.github.com/Mic92/262e6959fce375db5cd0407145545fc3

@markuskowa
Copy link
Member Author

That is strange. I can build it on NixOS 18.03.
For some reason it does not try execute the script register_extension.sh

shrinking /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2/bin/ambfor
shrinking /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2/bin/ambmd
shrinking /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2/bin/surf
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2/bin
patching script interpreter paths in /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2
checking for references to /build in /nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2...
/nix/store/42lc5bh4sgiil55na7lq6g5lq7acsgmn-molden-5.8.2

@markuskowa
Copy link
Member Author

Looking at the makefile: it turns on the "extension target" on if the detected OS is 'Ubuntu'.
I simply removed it. That feature, that it tries to register extension is new.

Mic92
Mic92 reviewed Aug 18, 2018
View reviewed changes
pkgs/applications/science/chemistry/molden/default.nix Outdated
@@ -19,6 +19,7 @@ stdenv.mkDerivation rec {
--replace 'sudo' "" \
--replace '-C surf depend' '-C surf'
sed -in '/^# DO NOT DELETE THIS LINE/q;' surf/Makefile
sed -i '/EXTEN.* = exten/d' makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make a patch for at least /makefile? Otherwise it becomes hard to spot what needs to be changed after an update (especially w.r.t. automated updates).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I implemented it as patch.

@Mic92
Copy link
Member

Mic92 commented Aug 18, 2018

I can build it now on my machine as well.

@Mic92 Mic92 merged commit 4609e3a into NixOS:master Aug 19, 2018
@markuskowa
Copy link
Member Author

Thanks for feedback!

@markuskowa markuskowa deleted the molden-up branch August 19, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @Mic92 @GrahamcOfBorg