Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/alertmanager: add clusterAdvertiseAddress option #45302

Closed
wants to merge 1 commit into from

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Aug 18, 2018

This is #45191 which I closed accidentally by rebasing my fork's master onto nixos-unstable, sorry about that. I don't know why it says it was merged, because there should have been nothing to merge.

Alertmanager fails to start when the memberlist library cannot find any private IP addresses on the system. This is a safeguard to avoid exposing cluster ports over the internet unintentionally. The workaround is to pass the --cluster.advertise-address argument to AlertManager.

See also:
prometheus/alertmanager#1437
prometheus/alertmanager#1434

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Alertmanager fails to start when the memberlist library cannot find any private
IP addresses on the system.  This is a safeguard to avoid exposing cluster ports
over the internet unintentionally.  The workaround is to pass the
--cluster.advertise-address argument to AlertManager.

See also:
prometheus/alertmanager#1437
prometheus/alertmanager#1434
@eqyiel
Copy link
Contributor Author

eqyiel commented Oct 7, 2018

This is not needed anymore since #46068 was merged, if necessary just pass the --cluster.advertise-address flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants