Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-qml: init at 2018-07-22 #45310

Merged
merged 1 commit into from Aug 19, 2018
Merged

vim-qml: init at 2018-07-22 #45310

merged 1 commit into from Aug 19, 2018

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Aug 18, 2018

Motivation for this change

Add vim plugin for editing Qt qml files.

Things done

Added vim-qml to vim-plugin-names. Added generated code to vim-plugins/default.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Aug 19, 2018

@GrahamcOfBorg build vimPlugins.vim-qml

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vimPlugins.vim-qml

Partial log (click to expand)

configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qc8i0plhd39bsljxgk418qvdsb7s01q8-vimplugin-vim-qml-2018-07-22
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qc8i0plhd39bsljxgk418qvdsb7s01q8-vimplugin-vim-qml-2018-07-22
/nix/store/qc8i0plhd39bsljxgk418qvdsb7s01q8-vimplugin-vim-qml-2018-07-22/share/vim-plugins/vim-qml/bin/update_contributors.sh: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/qc8i0plhd39bsljxgk418qvdsb7s01q8-vimplugin-vim-qml-2018-07-22...
/nix/store/qc8i0plhd39bsljxgk418qvdsb7s01q8-vimplugin-vim-qml-2018-07-22

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vimPlugins.vim-qml

Partial log (click to expand)

configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sfzm6mb053hzmp41ayjy7c3dm3yfn99d-vimplugin-vim-qml-2018-07-22
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sfzm6mb053hzmp41ayjy7c3dm3yfn99d-vimplugin-vim-qml-2018-07-22
/nix/store/sfzm6mb053hzmp41ayjy7c3dm3yfn99d-vimplugin-vim-qml-2018-07-22/share/vim-plugins/vim-qml/bin/update_contributors.sh: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/sfzm6mb053hzmp41ayjy7c3dm3yfn99d-vimplugin-vim-qml-2018-07-22...
/nix/store/sfzm6mb053hzmp41ayjy7c3dm3yfn99d-vimplugin-vim-qml-2018-07-22

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vimPlugins.vim-qml

Partial log (click to expand)

source root is vim-qml-8af43da
patching sources
configuring
building
installing
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/la4b2k0rf2gkdhvbi909xgy8k2znschz-vimplugin-vim-qml-2018-07-22
/nix/store/la4b2k0rf2gkdhvbi909xgy8k2znschz-vimplugin-vim-qml-2018-07-22/share/vim-plugins/vim-qml/bin/update_contributors.sh: interpreter directive changed from "/bin/sh" to "/nix/store/avxlkpsr36xpnsy0byq2c4vxk6sw157a-bash-4.4-p23/bin/sh"
/nix/store/la4b2k0rf2gkdhvbi909xgy8k2znschz-vimplugin-vim-qml-2018-07-22

LnL7
LnL7 approved these changes Aug 19, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit 4d659bc into NixOS:master Aug 19, 2018
@Thra11 Thra11 deleted the vim-qml branch August 19, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thra11 @LnL7 @GrahamcOfBorg