Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iputils: 20161105 -> 20180629 #45309

Merged
merged 1 commit into from Aug 19, 2018
Merged

iputils: 20161105 -> 20180629 #45309

merged 1 commit into from Aug 19, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 18, 2018 •
edited

Relevant changes

I don't see any relevant changes that should go into the NixOS changelog.
I've added the traceroute6 binary.
The build workflow for the man pages changed (SGML -> XML), but that shouldn't cause any problems.
Dependency changes: libidn -> libidn2 (and the build system for the man pages).
The code is still a bit hacky to be honest but it should be fine for now (I'll try to improve/refactor it soon).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • nixos/tests/ipv6.nix
    • nixos/tests/virtualbox.nix
    • nixos/tests/dnscrypt-proxy.nix
    • ...
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Result: 38112648 -> 3957059 (+1,457,944 or 3.8%)
  • Fits CONTRIBUTING.md.

Changes (git shortlog s20161105..s20180629):

Brian Norris (1):
ping: Fix signed overflow/conversion warning

Claudius Zingerli (1):
Ping: Correct rounding of timing displays

Cyril Hrubis (1):
ping_common.c: POLLERRR is ignored in events

David Heidelberg (37):
Merge pull request #67 from locasity/master
Merge pull request #69 from nmeyerhans/traceroute6
Merge pull request #87 from jsynacek/fix-pmtudisc
gitignore: prepare for Meson
meson: add experimental meson buildsystem support
ping: fix typo in error tos error message
ping: parsetos verification is enough, allow decimal values
ping: flowinfo: fixup checks for flowinfo and also add decimal numbers support
ping: fix conflicting defines
remove iputils.spec
RELNOTES: deprecated in favor of git history & github
travis-ci: cleanup and switch to Ubuntu 14.04 build
doc: convert from converting SGML to XML
Merge pull request #89 from metan-ucw/master
ping: fix incorrect packet loss calculation
LICENSE: add information about licenses
doc: ping - document mdev behaviour
LICENSE: convert BSD4 to BSD3 license
licenses: fill missing clockdiff.c and ping_common.c license
cleanup: really old code, simplify little bit
Merge pull request #103 from kerolasa/remove-libsysfs
Merge pull request #107 from jsynacek/master
Merge pull request #106 from kerolasa/tracepath-asan
Merge pull request #97 from nmav/tmp-idn2
Merge pull request #108 from Whissi/symlinked-tracepath-call
Merge pull request #101 from pevik/cleanup/working_recverr
Merge pull request #100 from pevik/fix-regression-57
Merge pull request #113 from pevik/doc/ping-modern-commands
Merge pull request #114 from pevik/doc/ping-no-need-to-use-link-specification
Merge pull request #116 from pevik/fix-readme
Merge pull request #75 from soheilhy/ping-errqueue
Merge pull request #126 from deastoe/ping6-device-bind
Merge pull request #123 from bbczeuz/dev_zseng_fix_time_rounding
Merge pull request #121 from pingz/patch-1
Merge pull request #131 from pevik/fix-ping-on-C-locale
Merge pull request #134 from computersforpeace/warnings
iputils-s20180629

Duncan Eastoe (1):
ping6: Fix device binding

Jan Synacek (5):
ping: prevent possible double free after cap_free()
arping: exit if network disappears while running
fix multicast setsockopt calls on big endian
ping: fix pmtu discovery for ipv6
ping: remove spurious error message

Nathaniel White (3):
traceroute6: Fix use after free for hostname
traceroute6: Fix leaking the idn memory
traceroute6: Fix traceroute to IPv6 address

Nikos Mavrogiannopoulos (6):
arping,tracepath: removed unused idna header
traceroute6: use getaddrinfo IDNA conversion
ping6: simplified IDNA usage
ping: use libidn2 instead of libidn
.travis.yml: install libidn2
.travis.yml: corrected variable values in matrix

Noah Meyerhans (1):
traceroute6: Fix udp packet port specification.

Petr Vorel (6):
ping: Remove workaround for bug in IP_RECVERR on raw sockets
Revert "correctly initialize first hop"
doc/ping: Replace deprecated commands in "SEE ALSO" section
doc/ping: Update Interface section
docs: Tiny fixes in README.md
ping: Fix ping name encoded using ACE on C locale

Sami Kerola (2):
arping: do not use libsysfs to read from /sys
tracepath: fix heap-buffer-overflow [asan]

Seishinryohosha (1):
tracepath,doc: Added -4, -6 Parameter in doc and void usage(void)

Singh (1):
Add strict pattern matching on response when pattern was provided

Soheil Hassas Yeganeh (1):
ping: read from error queue when POLLERR is set

Thomas Deutschmann (1):
tracepath: Support calling tracepath as tracepath4 or tracepath6

pingz (1):
fix checksum always success in IPv4 ping.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: iputils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iputils

Partial log (click to expand)

shrinking /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/bin/tracepath
shrinking /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/bin/rarpd
shrinking /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/bin/traceroute6
shrinking /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/bin/clockdiff
gzipping man pages under /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629/bin
patching script interpreter paths in /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629
checking for references to /build in /nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629...
/nix/store/3vsgk81mi88k9aprddyljjv23pwl9hdi-iputils-20180629

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iputils

Partial log (click to expand)

shrinking /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/bin/rarpd
shrinking /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/bin/ping
shrinking /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/bin/clockdiff
shrinking /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/bin/arping
gzipping man pages under /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629/bin
patching script interpreter paths in /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629
checking for references to /build in /nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629...
/nix/store/7mlf9wf4fn4kinmz19n0n23qhdanx6hi-iputils-20180629

@primeos primeos self-assigned this Aug 19, 2018
@primeos primeos merged commit b098041 into NixOS:master Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @GrahamcOfBorg