Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scs: init at 2.0.2 #45294

Merged
merged 1 commit into from Aug 23, 2018
Merged

scs: init at 2.0.2 #45294

merged 1 commit into from Aug 23, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Aug 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Aug 18, 2018

@GrahamcOfBorg build scs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scs

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2
shrinking /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2/lib/libscsindir.so
shrinking /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2/lib/libscsdir.so
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2/lib
patching script interpreter paths in /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2
checking for references to /build in /nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2...
/nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scs

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2
shrinking /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib/libscsindir.so
shrinking /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib/libscsdir.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib
/nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2
patching script interpreter paths in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2
checking for references to /build in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2...

bhipple
bhipple commented Aug 18, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -20619,6 +20619,10 @@ with pkgs;

petsc = callPackage ../development/libraries/science/math/petsc { };

scs = callPackage ../development/libraries/science/math/scs {
liblapack = liblapackWithoutAtlas;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this would be fine with atlas, but I couldn't get atlas to build on my system. It appears to be a source-only package so that it can do optimizations for your particular host CPU, so there are no Hydra binary caches and I figured ofborg probably wouldn't like it either.

bhipple
bhipple commented Aug 18, 2018
View reviewed changes
pkgs/development/libraries/science/math/scs/default.nix Outdated
checkPhase = ''
./out/demo_socp_indirect 42
'';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream makefile doesn't provide standard check/install targets, but I think these get the job done.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scs

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2
shrinking /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib/libscsdir.so
shrinking /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib/libscsindir.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2/lib
patching script interpreter paths in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2
checking for references to /build in /nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2...
/nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scs

Partial log (click to expand)

/nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scs

Partial log (click to expand)

/nix/store/laxb9jyrr6ij3h4amnml40y9j57hawxd-scs-2.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scs

Partial log (click to expand)

/nix/store/7mm6dsl08yam49n1wy1lxa1svww6kzdn-scs-2.0.2

@bhipple
Copy link
Contributor Author

bhipple commented Aug 19, 2018

Oops, initial version didn't cp -r include $out/; fixed up now and added a comment or two about the test suite. Should be good to go now:

$ tree $(nix-build . -A scs)
/nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2
├── include
│   ├── accel.h
│   ├── cones.h
│   ├── cs.h
│   ├── ctrlc.h
│   ├── glbopts.h
│   ├── linalg.h
│   ├── linsys.h
│   ├── normalize.h
│   ├── scs_blas.h
│   ├── scs.h
│   └── util.h
└── lib
    ├── libscsdir.a
    ├── libscsdir.so
    ├── libscsindir.a
    └── libscsindir.so

2 directories, 15 files

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scs

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2
shrinking /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2/lib/libscsdir.so
shrinking /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2/lib/libscsindir.so
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2/lib
patching script interpreter paths in /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2
checking for references to /build in /nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2...
/nix/store/bdj7nyivwwq7s2liphk6v508di9c67zn-scs-2.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scs

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2
shrinking /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2/lib/libscsindir.so
shrinking /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2/lib/libscsdir.so
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2/lib
patching script interpreter paths in /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2
checking for references to /build in /nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2...
/nix/store/z0zaakcqj4afk90qsb7ydxbi40r32ayb-scs-2.0.2

@xeji xeji merged commit 291de70 into NixOS:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @xeji