ghc: Use 8.2.2 binary for boot, no parallel builds on aarch64. #45313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisWhitaker
requested review from
basvandijk,
peti and
ryantm
as code owners
9 tasks
|
At least the parallel-build problem of aarch64 was discussed on #44482 |
|
Ah, someone beat me to it; sorry for missing that. I agree that |
TravisWhitaker
force-pushed
the
ghc822Binary-haskell-updates
branch
from
769d832
to
ac5810c
Compare
|
I don't quite understand the check-meta test this bot is doing. How can I re-run this on my machine? It looks like there's some issue with the definition of the |
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
b2a773d
to
2b2430d
Compare
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
b7c59d9
to
3ab4753
Compare
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
7b3d3e0
to
f705ee2
Compare
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
b6e6a8b
to
478eff0
Compare
peti
force-pushed
the
haskell-updates
branch
3 times, most recently
from
0ca4f8e
to
7247873
Compare
|
@TravisWhitaker can you rebase just your last commit onto master or haskell-updates? Also, we should leave the aarch64 parallel building issue to #44482 and ignore it in this PR. |
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
4462938
to
582d7e2
Compare
peti
force-pushed
the
haskell-updates
branch
12 times, most recently
from
cbcdf37
to
2bf4496
Compare
peti
force-pushed
the
haskell-updates
branch
5 times, most recently
from
cb2e918
to
eea0e2f
Compare
peti
force-pushed
the
haskell-updates
branch
6 times, most recently
from
367d0eb
to
79cfb44
Compare
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
9c35b0f
to
5c582f3
Compare
|
Is this still relevant? If not, I'd suggest closing. |
|
Nope, other PRs have addressed this. Thanks for flagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GHC 8.2.1 is rather broken. Upstream's build system actually complains if you attempt to build with it (see this bug). This is especially true of aarch64. It would be nice to bootstrap with upstream's binary 8.2.2 instead.
This bug also severely affects GHC on aarch64, and without disabling parallel building GHC is next to useless on that platform. Until a fix for that bug makes it into a release, it would be better to disable parallel builds on aarch64.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)