Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmsgpack: 2.1.5 -> 3.0.1 #45283

Merged
merged 1 commit into from Aug 18, 2018
Merged

libmsgpack: 2.1.5 -> 3.0.1 #45283

merged 1 commit into from Aug 18, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Aug 17, 2018 •
edited

Motivation for this change

The major version change is only due to this bug fix, which affects the reported offset in a malformed msgpack message after trying to parse it (and the previously reported offset was useless). This is not likely to have an effect on any software compatible with msgpack 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libmsgpack

Partial log (click to expand)

-- Installing: /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1
shrinking /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1/lib
patching script interpreter paths in /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1
checking for references to /build in /nix/store/0ml48048vsjvcpn6jpyhs913g1zas7kv-libmsgpack-3.0.1...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libmsgpack

Partial log (click to expand)

-- Installing: /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1
shrinking /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1/lib
patching script interpreter paths in /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1
checking for references to /build in /nix/store/v723wf6lw7778qx5fk99l0pjh8vq1wb8-libmsgpack-3.0.1...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libmsgpack

Partial log (click to expand)

-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/include/msgpack/zone_decl.hpp
-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib/pkgconfig/msgpack.pc
-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-targets.cmake
-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1/lib
patching script interpreter paths in /nix/store/l9w154rkrlkmi8r943k11xvn3r4xs271-libmsgpack-3.0.1

@orivej orivej mentioned this pull request Aug 18, 2018
Merged
9 tasks
@Mic92 Mic92 merged commit 5b3637d into NixOS:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @Mic92