gnuradio: PYTHONPATH and wrapper updates #47188
Conversation
tomberek
changed the title
|
|
||
| with { inherit (stdenv.lib) appendToName makeSearchPath; }; | ||
|
|
||
| stdenv.mkDerivation { | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
I think we should replace this whole derivation with python.buildEnv. We can improve that function by having a makeWrapperArgs parameter, which is a list of arguments passed along to makeWrapper.
There was a problem hiding this comment.
Is it possible (does it make sense) to use toPythonModule on the gnuradio modules?
There was a problem hiding this comment.
I agree that using python.buildEnv would be better, but I don't offhand know if the C++ side would be handled well. There is more work that needs to be done, but I wanted to go in smaller steps and prevent breaking the reverse dependencies.
Yes, toPythonModule builds the proper PYTHONPATH and also allows anyone loading this in nix-shell to use those modules.
There was a problem hiding this comment.
version bump merged. @FRidh what's next? This shouldn't be critical, just helps us with modules like gr-iio which abuse the gnuradio python namespace.
There was a problem hiding this comment.
do you suggest modifying python.buildEnv?
Yes. Let me do this tonight if I don't forget, or open a PR.
|
See #48310 for |
Motivation for this change
This change is in preparation for upcoming changes to gnuradio. The gnuradio python library must be present after other paths when there is a namespace conflict.
I will soon add a "master" or "unstable" version for the 3.8 tech-preview soon (https://github.com/gnuradio/gnuradio/releases/tag/3.8tech-preview).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)