Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] spotifyd: init at 0.2.2 #47172

Closed
wants to merge 2 commits into from
Closed

[WIP] spotifyd: init at 0.2.2 #47172

wants to merge 2 commits into from

Conversation

bobvanderlinden
Copy link
Member

Motivation for this change

Spotifyd is a daemon for Spotify. It is especially useful for headless servers that need to be able to play songs from Spotify.

This PR includes a basic implementation for a spotifyd module.

This PR is WIP because the package was not able to build. This problem is related to #30742.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bobvanderlinden bobvanderlinden mentioned this pull request Sep 22, 2018
Open
@anderslundstedt
Copy link
Contributor

Any progress on this? On the unstable channel, I was able to successfully build. But on execution it aborts as soon as I try to connect over Spotify Connect—illegal hardware instruction.

@bobvanderlinden
Copy link
Member Author

I still cannot get this to build. What have you done specifically to get the binaries?

@anderslundstedt
Copy link
Contributor

I checked out the nixos-unstable branch (at commit bc41317e24317b0f506287f2d5bab00140b9b50e). I then manually copied your spotifyd package (714034d), manually commenting out the cargoBuildFlags line. Then nix-env -iA nixpkgs.spotifyd worked.

@jmgrosen jmgrosen mentioned this pull request Feb 17, 2019
Closed
10 tasks
@flokli
Copy link
Contributor

flokli commented Feb 17, 2019

closing in favor of #55923.

@flokli flokli closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bobvanderlinden @anderslundstedt @flokli @samueldr @GrahamcOfBorg