Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: disallow cc in perl #47207

Merged
merged 1 commit into from Sep 23, 2018
Merged

perl: disallow cc in perl #47207

merged 1 commit into from Sep 23, 2018

Conversation

matthewbauer
Copy link
Member

Fixes #46077

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: perl

Partial log (click to expand)

cannot build derivation '/nix/store/rz1px53nf21xyxl9yf1ac0x0avsnhcb5-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5lfg0ld7ng28y2rkw13fnahj22lxkgpx-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/4x0aziy9q50jsyjy0l785psagqbq6ddd-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/5h9fsw8j5hrr94jxrswg2knm2wqf9j91-clang-wrapper-5.0.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/9kpqhy6kipicip68zm0dmcnl62rr6z3j-libkrb5-1.15.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/majzippsmhrsi0kfikff5fdm49jcc4y8-curl-7.61.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/2vpazscirkvy47spsds7ghv9ca6cjyc4-swift-corefoundation.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/b9gnd456qbnv6xlhqq8a0pbxc5r59i5i-stdenv-darwin.drv': 42 dependencies couldn't be built
cannot build derivation '/nix/store/qsiia4034g244p32dlskr5g8faw1gd0z-perl-5.28.0.drv': 5 dependencies couldn't be built
error: build of '/nix/store/qsiia4034g244p32dlskr5g8faw1gd0z-perl-5.28.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: perl

Partial log (click to expand)

cannot build derivation '/nix/store/jc1hhs62vmfshxw92k39nzky0zjf106y-binutils-wrapper-2.30.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ld6ni9j7c2sp1mkwsr3vzirizdbgbjhn-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/46h26apj33kxhap9hvbaycghghlk7dw5-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/n6mz8hl1q04vwgcfbhvwrh64a000m1x6-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p81zfs6asak3v486vq5n1dnq5h7a9d8b-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/2jwhamy3nrb1yr8ny50g4vhwr854khff-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4ab5h2xix4j4xaknsd880s8ggxgw15ny-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/w66j5r7j6lxpd6nnzdyd1wx8h1whwwih-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/x72nnb60d6gv0i8z5f2h9drykps65l13-perl-5.28.0.drv': 4 dependencies couldn't be built
error: build of '/nix/store/x72nnb60d6gv0i8z5f2h9drykps65l13-perl-5.28.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: perl

Partial log (click to expand)

gzipping man pages under /nix/store/z09ip74kg61j6nin6200ivj5wgvyl5y6-perl-5.28.0-man/share/man/
strip is /nix/store/338kyqvbhhyr0qayq3mv01k0axc1sld4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/z09ip74kg61j6nin6200ivj5wgvyl5y6-perl-5.28.0-man
checking for references to /build in /nix/store/z09ip74kg61j6nin6200ivj5wgvyl5y6-perl-5.28.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/sz0ckqzvqj99yyxg55gkg1sbqh4k75n0-perl-5.28.0-devdoc
gzipping man pages under /nix/store/sz0ckqzvqj99yyxg55gkg1sbqh4k75n0-perl-5.28.0-devdoc/share/man/
strip is /nix/store/338kyqvbhhyr0qayq3mv01k0axc1sld4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sz0ckqzvqj99yyxg55gkg1sbqh4k75n0-perl-5.28.0-devdoc
checking for references to /build in /nix/store/sz0ckqzvqj99yyxg55gkg1sbqh4k75n0-perl-5.28.0-devdoc...
/nix/store/wpnrw8lk9r0s1d02yhqjc812iyi0iy6b-perl-5.28.0

vcunat
vcunat approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, tested one bootstrapping step on x86_64-linux.

Disallowing stdenv.cc.cc might be better (though it might need some or part for bootstrapping), killing two birds with one stone, but it seems good this way. EDIT: that would need using disallowedRequisites instead; I tend to confuse those two :-/

xeji
xeji reviewed Sep 23, 2018
View reviewed changes
pkgs/development/interpreters/perl/default.nix
@@ -118,6 +120,7 @@ let
--replace "${
if stdenv.cc.cc or null != null then stdenv.cc.cc else "/no-such-path"
}" /no-such-path \
--replace "${stdenv.cc}" /no-such-path \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very similar to the substitution above, which seems to do the same job for x86_64-linux.
What exactly is the difference between stdenv.cc and stdenv.cc.cc ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is wrapped and other is unwrapped. (that should hold for any platform)

@matthewbauer matthewbauer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 23, 2018
@matthewbauer matthewbauer merged commit 1733030 into NixOS:staging Sep 23, 2018
@samueldr
Copy link
Member

@matthewbauer I see you added port to stable, I don't see any backport.

~/tmp/nixpkgs/nixpkgs $ git log master --format='%H %an' --grep="disallow reference to cc" | wc -l
1
~/tmp/nixpkgs/nixpkgs $ git log release-18.09 --format='%H %an' --grep="disallow reference to cc" | wc -l
0
~/tmp/nixpkgs/nixpkgs $ git log staging-18.09 --format='%H %an' --grep="disallow reference to cc" | wc -l
0

I'm assuming this would first go through staging-18.09 right? Should this be scheduled not to conflict with the existing stuff in staging-18.09?

@matthewbauer
Copy link
Member Author

Yeah forgot to do that. It's not super important but definitely useful.

@matthewbauer matthewbauer deleted the disallow-cc-in-perl branch February 22, 2019 04:25
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthewbauer @GrahamcOfBorg @samueldr @vcunat @xeji @nixos-discourse