Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sddm: link whole sddm directory, not just themes #47174

Merged
merged 1 commit into from Sep 22, 2018

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

SDDM has a number of other important files in there, which won't be linked otherwise. Also, this way other packages can now contribute translations etc.

(This currently doesn't bite you if you use most DEs because of #47173)

I tested this by building a system without my DE and it now links the paths properly where it didn't before.

@jtojnar finally remembered to do this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg test sddm

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.sddm

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.sddm

No partial log is available.

@xeji xeji merged commit 5b3c848 into NixOS:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants