Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luadbi: 0.5 -> 0.6 #47156

Merged
merged 1 commit into from Sep 22, 2018
Merged

luaPackages.luadbi: 0.5 -> 0.6 #47156

merged 1 commit into from Sep 22, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 22, 2018 •
edited

Switch to maintained fork that is compatible with lua5.2/lua5.3.
This package was tested with prosody (the only user in nixpkgs itself).
Since it was not actually compatible with lua5.2 before I would recommend to backport it,
otherwise prosody will not work.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
luaPackages.luadbi: 0.5 -> 0.6
66f3df9 
Switch to maintained fork that is compatible with lua5.2/lua5.3.
This package was tested with prosody.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: luaPackages.luadbi

Partial log (click to expand)

install -D dbd/mysql.so /nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/mysql.so
clang build/dbd_common.o build/dbd_postgresql_main.o build/dbd_postgresql_connection.o build/dbd_postgresql_statement.o -o dbd/postgresql.so -I/nix/store/9mbpcss9vablrmzsz8k0fy696bxbdc2v-lua-5.2.3/include -g -pedantic -Wall -O2 -bundle -undefined dynamic_lookup -all_load -fPIC -DPIC -std=c99  -I. -bundle -undefined dynamic_lookup -all_load  -I/usr/include/postgresql -lpq
install -D dbd/postgresql.so /nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/postgresql.so
clang build/dbd_common.o build/dbd_sqlite3_main.o build/dbd_sqlite3_connection.o build/dbd_sqlite3_statement.o -o dbd/sqlite3.so -I/nix/store/9mbpcss9vablrmzsz8k0fy696bxbdc2v-lua-5.2.3/include -g -pedantic -Wall -O2 -bundle -undefined dynamic_lookup -all_load -fPIC -DPIC -std=c99  -I. -bundle -undefined dynamic_lookup -all_load  -I/usr/include -lsqlite3
install -D dbd/sqlite3.so /nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/sqlite3.so
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6/lib
patching script interpreter paths in /nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6
/nix/store/kyd2hvqnxhfgiay6vi68rsq9pppsyvms-lua5.2-luadbi-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luaPackages.luadbi

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6
shrinking /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/postgresql.so
shrinking /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/mysql.so
shrinking /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/sqlite3.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6/lib
patching script interpreter paths in /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6
checking for references to /build in /nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6...
/nix/store/asdq6grnyj9j8d4vsqx11flkprsnqw58-lua5.2-luadbi-0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luaPackages.luadbi

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6
shrinking /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/sqlite3.so
shrinking /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/postgresql.so
shrinking /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6/lib/lua/5.2/dbd/mysql.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6/lib
patching script interpreter paths in /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6
checking for references to /build in /nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6...
/nix/store/zl04zwkfqx27gqqwhf7i3h6psc6ivhc2-lua5.2-luadbi-0.6

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build prosody

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: prosody

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prosody

Partial log (click to expand)

shrinking /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/lib/prosody/util/hashes.so
shrinking /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/lib/prosody/util/encodings.so
gzipping man pages under /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/lib  /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/bin
patching script interpreter paths in /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2
/nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/bin/.prosodyctl-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/g5d2jki3nmpq2mksf8k5psnbs9f0mrfd-lua-5.2.4/bin/lua"
/nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2/bin/.prosody-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/g5d2jki3nmpq2mksf8k5psnbs9f0mrfd-lua-5.2.4/bin/lua"
checking for references to /build in /nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2...
/nix/store/gg5fagb44rk5giq7w1isj96i13nddiii-prosody-0.10.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prosody

Partial log (click to expand)

shrinking /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/lib/prosody/util/ringbuffer.so
shrinking /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/lib/prosody/util/table.so
gzipping man pages under /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/lib  /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/bin
patching script interpreter paths in /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2
/nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/bin/.prosodyctl-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/3j8s75zamc7sicpawszdk6i5ljwl41s2-lua-5.2.4/bin/lua"
/nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2/bin/.prosody-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/3j8s75zamc7sicpawszdk6i5ljwl41s2-lua-5.2.4/bin/lua"
checking for references to /build in /nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2...
/nix/store/2sgb4y77j6z43ghznsqfji1jmrqznz3h-prosody-0.10.2

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg test prosody

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 92.99s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lbi9d1jbcqhnprv2ai833svrzqzcb92x-vm-test-run-prosody

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 90.74s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/dqcm09r5ns09chrbyh0gf3q3amw7dp45-vm-test-run-prosody

@xeji xeji mentioned this pull request Sep 22, 2018
Merged
1 task
@xeji xeji merged commit a8413d8 into NixOS:master Sep 22, 2018
xeji pushed a commit that referenced this pull request Sep 22, 2018
@Mic92 @xeji
luaPackages.luadbi: 0.5 -> 0.6 (#47156)
2de47a7 
Switch to maintained fork that is compatible with lua5.2/lua5.3.
This package was tested with prosody.

(cherry picked from commit a8413d8)

Backported because prosody database access is broken without it.
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

backported to 18.09: 2de47a7

@Mic92 Mic92 deleted the luadbi branch September 22, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @xeji