Fix rmilter socket path, add deprecation notice #47180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run/rmilter is set by systemd, and have root:root ownership, which prevent pid file to write. This fix suggested to be promoted to 18.09 branch. (Although rmilter itself is deprecated, and I plan to remove it, after 18.09 would be released)
|
See also #46637 |
Mic92
reviewed
Sep 23, 2018
| @@ -193,6 +193,9 @@ in | |||
| config = mkMerge [ | |||
|
|
|||
| (mkIf cfg.enable { | |||
| warnings = [ | |||
| ''`config.serivces.rmilter' is deprecated, `rmilter' deprecated and unsupported by upstream, and would be removed from next releases '' | |||
There was a problem hiding this comment.
config.services.rmilter and will be removed.
|
On Sun, Sep 23, 2018 at 06:43:43AM -0700, Jörg Thalheim wrote:
> @@ -193,6 +193,9 @@ in
config = mkMerge [
(mkIf cfg.enable {
+ warnings = [
+ ''`config.serivces.rmilter' is deprecated, `rmilter' deprecated and unsupported by upstream, and would be removed from next releases ''
`config.services.rmilter` and `will be removed`.
@Mic92 thank you. Fixed, and added suggestion to use rspamd builtin
milter as well.
|
|
If you are going to remove rmilter before the 19.03 release, we should backport both commits right? |
|
On Sun, Sep 23, 2018 at 05:15:56PM -0700, Jörg Thalheim wrote:
If you are going to remove rmilter before the 19.03 release, we should backport both commits right?
Thats plan.
If you suggest a slower upgrade path, we can backport only first commit
(with socket path bugfix), announce deprecation in post 18.09, and
remove it right after 19.03 branch.
But rmilter itself was added only as requirement to operate rspamd (0.6
was unable operate as milter directly, but 0.7+ can, and rmilter can be
avoided). So I suggest to all users switch to builtin rspamd's milter.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Putting socket and pid file in same workdir cause problem, so I moved socket out of workdir.
Also as rmilter is no more recomended (use built-in rspamd milter instead), deprecation notice was added.
/cc @samueldr this commits suggested for release-18.09 branch
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)