-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: Refactor so we can upgrade PHP per platform #47162
Conversation
This way we don't need to disable flags etc by platform and can still backport new versions to stable for linux even if there's a bug or something in the darwin build.
@GrahamcOfBorg eval |
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
@GrahamcOfBorg build php71 php72 |
Success on x86_64-linux (full log) Attempted: php71, php72 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php71, php72 Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: php71, php72 Partial log (click to expand)
|
Fails on Darwin... This is ok as an interim solution but I think it should be reverted asap. I'm not entirely happy with the idea of having platform-dependent versions of packages. Having this split already in the code may tempt maintainers to just ignore build errors on platforms they don't care about, which is probably not what we want. |
@xeji Yeah, I agree. But I also don't like the thought of not being upgrade the users on stable linuxes. I pushed a fixup that we can try with on darwin on I also sent a PR to ofborg to be able to trigger darwin builds myself... |
@GrahamcOfBorg build php71 php72 |
Success on x86_64-linux (full log) Attempted: php71, php72 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php71, php72 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: php71, php72 Partial log (click to expand)
|
@etu I squashed the two commits into one, looks nicer. |
This way we don't need to disable flags etc by platform and can still backport new versions to stable for linux even if there's a bug or something in the darwin build. (cherry picked from commit 0b82fbc)
Yeah, if you wouldn't do that I would before merging. Just wanted to keep track of the changes in between builds. Hence the
Nice, thanks. Feels good to have working builds. And I will try to upgrade the darwin ones whenever new versions gets released 👍 |
Squashing during merge is no work at all thanks to Github's nice "squash and merge" button 😄 |
Hehe, the |
cool, didn't know that! |
Motivation for this change
This way we don't need to disable flags etc by platform and can still
backport new versions to stable for linux even if there's a bug or
something in the darwin build.
We would need to trigger a build on darwin as well.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @xeji