Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsndfile: Add patch for CVE-2018-13139 #47160

Closed
wants to merge 1 commit into from
Closed

libsndfile: Add patch for CVE-2018-13139 #47160

wants to merge 1 commit into from

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Sep 22, 2018 •
edited

Motivation for this change

Add patch for CVE-2018-13139 (ref #47121) by applying the upstream patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andrew-d
Copy link
Contributor Author

cc @lovek323 as package maintainer

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build libsndfile

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libsndfile

Partial log (click to expand)

/nix/store/j8637darl6q7rysyg706c0s1jf42wg29-libsndfile-1.0.28/lib/libsndfile.1.dylib: fixing dylib
/nix/store/j8637darl6q7rysyg706c0s1jf42wg29-libsndfile-1.0.28/lib/libsndfile.1.dylib: fixing dylib
/nix/store/j8637darl6q7rysyg706c0s1jf42wg29-libsndfile-1.0.28/lib/libsndfile.1.dylib: fixing dylib
/nix/store/j8637darl6q7rysyg706c0s1jf42wg29-libsndfile-1.0.28/lib/libsndfile.1.dylib: fixing dylib
gzipping man pages under /nix/store/k1zbwkvvyqa14kvnqkgzkjn4jr88mac5-libsndfile-1.0.28-man/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/k1zbwkvvyqa14kvnqkgzkjn4jr88mac5-libsndfile-1.0.28-man
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/9ifrav51wxzl7igzhy55whwrphp11ijw-libsndfile-1.0.28-doc
/nix/store/h9ppm8bs64yr0cqvidkwr4syac896iqk-libsndfile-1.0.28-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libsndfile

Partial log (click to expand)

checking for references to /build in /nix/store/yds3kxq3jqi9wcsxvp4ncazjgnb0p9n8-libsndfile-1.0.28...
shrinking RPATHs of ELF executables and libraries in /nix/store/32aw8bkpvx4vg67basy8945gbjxav5fm-libsndfile-1.0.28-man
gzipping man pages under /nix/store/32aw8bkpvx4vg67basy8945gbjxav5fm-libsndfile-1.0.28-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/32aw8bkpvx4vg67basy8945gbjxav5fm-libsndfile-1.0.28-man
checking for references to /build in /nix/store/32aw8bkpvx4vg67basy8945gbjxav5fm-libsndfile-1.0.28-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/8zl0b3ik7gl9fmplyjinn67x7z9xb9ky-libsndfile-1.0.28-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8zl0b3ik7gl9fmplyjinn67x7z9xb9ky-libsndfile-1.0.28-doc
checking for references to /build in /nix/store/8zl0b3ik7gl9fmplyjinn67x7z9xb9ky-libsndfile-1.0.28-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libsndfile

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/nknsmpc96w4xjyplia5gssicfw5c9rn3-libsndfile-1.0.28-man
gzipping man pages under /nix/store/nknsmpc96w4xjyplia5gssicfw5c9rn3-libsndfile-1.0.28-man/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/nknsmpc96w4xjyplia5gssicfw5c9rn3-libsndfile-1.0.28-man
checking for references to /build in /nix/store/nknsmpc96w4xjyplia5gssicfw5c9rn3-libsndfile-1.0.28-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/2xh5jn80yzyhgrc3rxlxr0kdra9pg7zi-libsndfile-1.0.28-doc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2xh5jn80yzyhgrc3rxlxr0kdra9pg7zi-libsndfile-1.0.28-doc
checking for references to /build in /nix/store/2xh5jn80yzyhgrc3rxlxr0kdra9pg7zi-libsndfile-1.0.28-doc...
/nix/store/nqn36mgadwvjimhbp6gcg2wvcy7mriwm-libsndfile-1.0.28-bin

xeji pushed a commit that referenced this pull request Sep 22, 2018
@andrew-d @xeji
libsndfile: Add patch for CVE-2018-13139 (#47160)
fcde178
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

picked to staging (because it's a mass rebuild) in fcde178

@xeji xeji closed this Sep 22, 2018
xeji pushed a commit that referenced this pull request Sep 22, 2018
@andrew-d @xeji
libsndfile: Add patch for CVE-2018-13139 (#47160)
ad9e8ea 
(cherry picked from commit fcde178)
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

backported to staging-18.09 in ad9e8ea

@ckauhaus ckauhaus mentioned this pull request Sep 22, 2018
Closed
17 tasks
@andrew-d andrew-d deleted the andrew/libsndfile-CVE-2018-13139 branch September 22, 2018 20:54
@andrew-d
Copy link
Contributor Author

@xeji - Thanks! And thanks for the cherry-pick, too; didn't realize this was going to be a mass rebuild.

vcunat pushed a commit that referenced this pull request Sep 23, 2018
@andrew-d @vcunat
libsndfile: Add patch for CVE-2018-13139 (#47160)
efd74a6 
(cherry picked from commit fcde178)
@vcunat
Copy link
Member

vcunat commented Sep 23, 2018

That's what the bot is for!

I also picked this to 18.03; I'm not sure why it didn't appear in the roundup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrew-d @xeji @GrahamcOfBorg @vcunat